Issue 1766623002: Deprecate gfe2_reloadable_flag_enable_quic_fec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1766623002: Deprecate gfe2_reloadable_flag_enable_quic_fec. (Closed)

Created:
4 years, 9 months ago by danzh1

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Fan Yang

Base URL:
https://chromium.googlesource.com/chromium/src.git@115603675

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Deprecate gfe2_reloadable_flag_enable_quic_fec. Disable the ability to enable FEC protection via connection options. First change to remove FEC. Merge internal change: 115690862 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Update dependency #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -73 lines)			Patch
M	net/quic/quic_client_session_base.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	net/tools/quic/quic_client_session_test.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	net/tools/quic/quic_server_session_base.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/tools/quic/quic_server_session_base_test.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download

Depends on Patchset:

Issue 1761253002 Patch 20001

Dependent Patchsets:

Issue 1764913002 Patch 20001

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm lgtm, but please edit the CL description to fix the flag name.

4 years, 9 months ago (2016-03-04 15:01:26 UTC) #2

danzh1

4 years, 9 months ago (2016-03-04 15:26:42 UTC) #3

On 2016/03/04 15:01:26, Ryan Hamilton wrote:
> lgtm
> 
> lgtm, but please edit the CL description to fix the flag name.

will to in the Final CL

Expand Messages | Collapse Messages