Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1766623002: Deprecate gfe2_reloadable_flag_enable_quic_fec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115603675
Patch Set: Update dependency Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index c6d914dc640fbd2b5cc71e67dd028cc241125d38..08e2c8bc288f42dcc2c622a6219734c872ad6a18 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -266,7 +266,6 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
client_supported_versions_ = GetParam().client_supported_versions;
server_supported_versions_ = GetParam().server_supported_versions;
negotiated_version_ = GetParam().negotiated_version;
- FLAGS_enable_quic_fec = GetParam().use_fec;
VLOG(1) << "Using Configuration: " << GetParam();
@@ -371,10 +370,6 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
StartServer();
client_.reset(CreateQuicClient(client_writer_));
- if (GetParam().use_fec) {
- // Set FecPolicy to always protect data on all streams.
- client_->SetFecPolicy(FEC_PROTECT_ALWAYS);
- }
static EpollEvent event(EPOLLOUT, false);
client_writer_->Initialize(
reinterpret_cast<QuicEpollConnectionHelper*>(
@@ -998,8 +993,7 @@ TEST_P(EndToEndTest, CorrectlyConfiguredFec) {
client_->client()->WaitForCryptoHandshakeConfirmed();
server_thread_->WaitForCryptoHandshakeConfirmed();
- FecPolicy expected_policy =
- GetParam().use_fec ? FEC_PROTECT_ALWAYS : FEC_PROTECT_OPTIONAL;
+ FecPolicy expected_policy = FEC_PROTECT_OPTIONAL;
// Verify that server's FEC configuration is correct.
server_thread_->Pause();
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698