Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1766323002: [mips] Mask ror immediates. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mips] Mask ror immediates. R=ahaas@chromium.org BUG= Committed: https://crrev.com/e3a041c5d3b9b00e78b262888de53419a1771bf8 Cr-Commit-Position: refs/heads/master@{#34530}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/mips/macro-assembler-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
4 years, 9 months ago (2016-03-07 09:56:45 UTC) #1
ahaas
lgtm
4 years, 9 months ago (2016-03-07 10:13:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766323002/20001
4 years, 9 months ago (2016-03-07 11:37:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 11:54:27 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 11:55:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e3a041c5d3b9b00e78b262888de53419a1771bf8
Cr-Commit-Position: refs/heads/master@{#34530}

Powered by Google App Engine
This is Rietveld 408576698