X87: Disable the test-run-profiler/Inlining test case for X87.

X87: Disable the test-run-profiler/Inlining test case for X87.

  The CL #34376 (https://codereview.chromium.org/1740073002 ) added the Inlining test case and X87 failed at it.

  The reason is:
  For TEST(Inlining) test case, when level3 function is inlined, the key optimized crankshaft code will like below code normally:
  ............
  0x21d53b7f    63  ff571b         call [edi+0x1b]           <-----------  should call action() here
                    ;;; <@32,#27> lazy-bailout
                    ;;; <@36,#31> ---- B3 ----
                    ;;; <@37,#31> gap
  0x21d53b82    66  89c1           mov ecx,eax               <-----------  Both the inlined function’s pc_offset from DeoptimizationInputData and the pc_offset from sample stack points to here, the same pc address
  ............

  So the TEST(Inlining) test case can get the expected inlined code entry and pass..

  In fact, the exact code sequence should like the following in crankshaft:
  ............
  0x21d53b7f    63  ff571b         call [edi+0x1b]                 <-----------  should call action()
  0xxxxxxxxx    xxxx               GenerateBodyInstructionPost()   <-----------  the pc_offset from sample stack points to here
                    ;;; <@32,#27> lazy-bailout
                    ;;; <@36,#31> ---- B3 ----
                    ;;; <@37,#31> gap
  0x21d53b82    66  89c1           mov ecx,eax                     <-----------  the inlined function’s pc_offset from DeoptimizationInputData points to here.
  ............

  For most of architectures in V8, the GenerateBodyInstructionPost()  is empty, so both the inlined function’s pc_offset from DeoptimizationInputData and the pc_offset from sample stack points to  the same pc address .

  But if some architecture has special requirement and need to put some instruction after call instruction, the GenerateBodyInstructionPost() will do that work and generate instructions,  the inlined function’s pc_offset from DeoptimizationInputData and The pc_offset  from sample stack will points to  the different  pc address, the TEST(Inlining) test case can’t get the expected inlined code entry and failed.

  For all current architectures in v8, only x87 have this requirement.

  After communicated with Alexei Filippov <alph@chromium.org>; in E-mail, we decided to disable the Inlining test case for x87 now and try to find a solution.

BUG=

Committed: https://crrev.com/e906c9caefdb5f740f54bdfc73b62e37b3a2ef6a
Cr-Commit-Position: refs/heads/master@{#34544}

[zhengxing.li, 2016-03-07 06:10:06]

zhengxing.li@intel.com changed reviewers:
+ alph@chromium.org, chunyang.dai@intel.com, titzer@chromium.org,
weiliang.lin@intel.com

[zhengxing.li, 2016-03-07 06:10:06]

PTAL, thanks!

[titzer, 2016-03-07 14:29:24]

lgtm. Thanks for the detailed explanation.

[zhengxing.li, 2016-03-07 14:36:51]

On 2016/03/07 14:29:24, titzer wrote:
> lgtm. Thanks for the detailed explanation.

Thanks, titzer!

[zhengxing.li, 2016-03-07 14:37:05]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-03-07 14:37:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766263002/1

[commit-bot: I haz the power, 2016-03-07 14:56:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-07 14:57:11]

Description was changed from

==========
X87: Disable the test-run-profiler/Inlining test case for X87.

  The CL #34376 (https://codereview.chromium.org/1740073002 ) added the Inlining
test case and X87 failed at it.

  The reason is:
  For TEST(Inlining) test case, when level3 function is inlined, the key
optimized crankshaft code will like below code normally:
  ............
  0x21d53b7f    63  ff571b         call [edi+0x1b]           <----------- 
should call action() here
                    ;;; <@32,#27> lazy-bailout
                    ;;; <@36,#31> ---- B3 ----
                    ;;; <@37,#31> gap
  0x21d53b82    66  89c1           mov ecx,eax               <-----------  Both
the inlined function’s pc_offset from DeoptimizationInputData and the pc_offset
from sample stack points to here, the same pc address
  ............

  So the TEST(Inlining) test case can get the expected inlined code entry and
pass..

  In fact, the exact code sequence should like the following in crankshaft:
  ............
  0x21d53b7f    63  ff571b         call [edi+0x1b]                 <----------- 
should call action()
  0xxxxxxxxx    xxxx               GenerateBodyInstructionPost()   <----------- 
the pc_offset from sample stack points to here
                    ;;; <@32,#27> lazy-bailout
                    ;;; <@36,#31> ---- B3 ----
                    ;;; <@37,#31> gap
  0x21d53b82    66  89c1           mov ecx,eax                     <----------- 
the inlined function’s pc_offset from DeoptimizationInputData points to here.
  ............

  For most of architectures in V8, the GenerateBodyInstructionPost()  is empty,
so both the inlined function’s pc_offset from DeoptimizationInputData and the
pc_offset from sample stack points to  the same pc address .

  But if some architecture has special requirement and need to put some
instruction after call instruction, the GenerateBodyInstructionPost() will do
that work and generate instructions,  the inlined function’s pc_offset from
DeoptimizationInputData and The pc_offset  from sample stack will points to  the
different  pc address, the TEST(Inlining) test case can’t get the expected
inlined code entry and failed.

  For all current architectures in v8, only x87 have this requirement.

  After communicated with Alexei Filippov <alph@chromium.org> in E-mail, we
decided to disable the Inlining test case for x87 now and try to find a
solution.

BUG=
==========

to

==========
X87: Disable the test-run-profiler/Inlining test case for X87.

  The CL #34376 (https://codereview.chromium.org/1740073002 ) added the Inlining
test case and X87 failed at it.

  The reason is:
  For TEST(Inlining) test case, when level3 function is inlined, the key
optimized crankshaft code will like below code normally:
  ............
  0x21d53b7f    63  ff571b         call [edi+0x1b]           <----------- 
should call action() here
                    ;;; <@32,#27> lazy-bailout
                    ;;; <@36,#31> ---- B3 ----
                    ;;; <@37,#31> gap
  0x21d53b82    66  89c1           mov ecx,eax               <-----------  Both
the inlined function’s pc_offset from DeoptimizationInputData and the pc_offset
from sample stack points to here, the same pc address
  ............

  So the TEST(Inlining) test case can get the expected inlined code entry and
pass..

  In fact, the exact code sequence should like the following in crankshaft:
  ............
  0x21d53b7f    63  ff571b         call [edi+0x1b]                 <----------- 
should call action()
  0xxxxxxxxx    xxxx               GenerateBodyInstructionPost()   <----------- 
the pc_offset from sample stack points to here
                    ;;; <@32,#27> lazy-bailout
                    ;;; <@36,#31> ---- B3 ----
                    ;;; <@37,#31> gap
  0x21d53b82    66  89c1           mov ecx,eax                     <----------- 
the inlined function’s pc_offset from DeoptimizationInputData points to here.
  ............

  For most of architectures in V8, the GenerateBodyInstructionPost()  is empty,
so both the inlined function’s pc_offset from DeoptimizationInputData and the
pc_offset from sample stack points to  the same pc address .

  But if some architecture has special requirement and need to put some
instruction after call instruction, the GenerateBodyInstructionPost() will do
that work and generate instructions,  the inlined function’s pc_offset from
DeoptimizationInputData and The pc_offset  from sample stack will points to  the
different  pc address, the TEST(Inlining) test case can’t get the expected
inlined code entry and failed.

  For all current architectures in v8, only x87 have this requirement.

  After communicated with Alexei Filippov <alph@chromium.org> in E-mail, we
decided to disable the Inlining test case for x87 now and try to find a
solution.

BUG=

Committed: https://crrev.com/e906c9caefdb5f740f54bdfc73b62e37b3a2ef6a
Cr-Commit-Position: refs/heads/master@{#34544}
==========

[commit-bot: I haz the power, 2016-03-07 14:57:12]

Patchset 1 (id:??) landed as
https://crrev.com/e906c9caefdb5f740f54bdfc73b62e37b3a2ef6a
Cr-Commit-Position: refs/heads/master@{#34544}