Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1740073002: Make CPU profiler unwind the inlined functions stack. (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make CPU profiler unwind the inlined functions stack. BUG=575466 LOG=N Committed: https://crrev.com/b01cd96eb503964d991b06ca6ed39ee946619012 Cr-Commit-Position: refs/heads/master@{#34376}

Patch Set 1 #

Total comments: 4

Patch Set 2 : make the test deterministic. #

Patch Set 3 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -50 lines) Patch
M src/profiler/cpu-profiler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 1 2 6 chunks +52 lines, -0 lines 0 comments Download
M src/profiler/profile-generator.h View 6 chunks +10 lines, -5 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 2 11 chunks +54 lines, -35 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 2 5 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740073002/1
4 years, 10 months ago (2016-02-26 02:35:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 02:53:16 UTC) #4
alph
Benedikt, could you please take a look.
4 years, 10 months ago (2016-02-26 02:58:38 UTC) #6
alph
4 years, 10 months ago (2016-02-26 15:47:00 UTC) #8
titzer
https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc#newcode1551 test/cctest/test-cpu-profiler.cc:1551: TEST(Inlining) { Is there a way to make this ...
4 years, 10 months ago (2016-02-26 21:24:01 UTC) #9
alph
https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc#newcode1551 test/cctest/test-cpu-profiler.cc:1551: TEST(Inlining) { On 2016/02/26 21:24:01, titzer wrote: > Is ...
4 years, 10 months ago (2016-02-26 22:12:10 UTC) #10
titzer
https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc#newcode1551 test/cctest/test-cpu-profiler.cc:1551: TEST(Inlining) { On 2016/02/26 22:12:10, alph wrote: > On ...
4 years, 10 months ago (2016-02-26 23:46:52 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740073002/20001
4 years, 10 months ago (2016-02-27 01:32:33 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/14042) v8_linux_arm64_rel on ...
4 years, 10 months ago (2016-02-27 01:33:46 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740073002/40001
4 years, 10 months ago (2016-02-27 07:26:23 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-27 07:57:54 UTC) #19
alph
ptal https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc#newcode1551 test/cctest/test-cpu-profiler.cc:1551: TEST(Inlining) { On 2016/02/26 23:46:52, titzer wrote: > ...
4 years, 10 months ago (2016-02-27 08:24:02 UTC) #20
titzer
On 2016/02/27 08:24:02, alph wrote: > ptal > > https://codereview.chromium.org/1740073002/diff/1/test/cctest/test-cpu-profiler.cc > File test/cctest/test-cpu-profiler.cc (right): > ...
4 years, 9 months ago (2016-03-01 05:34:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740073002/40001
4 years, 9 months ago (2016-03-01 05:38:31 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-01 05:59:40 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 06:00:16 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b01cd96eb503964d991b06ca6ed39ee946619012
Cr-Commit-Position: refs/heads/master@{#34376}

Powered by Google App Engine
This is Rietveld 408576698