Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1766243002: Remove the leak expectation for web-animations-api/player-cancel-event.html since it seems to be wo… (Closed)

Created:
4 years, 9 months ago by dsansome
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the leak expectation for web-animations-api/player-cancel-event.html. It seems to have been fixed by https://codereview.chromium.org/1750453002 BUG=588598 Committed: https://crrev.com/bc817fe1b14552590efd801e683686074e928570 Cr-Commit-Position: refs/heads/master@{#379721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dsansome
4 years, 9 months ago (2016-03-07 04:30:06 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-03-07 04:31:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766243002/1
4 years, 9 months ago (2016-03-08 02:47:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 03:43:58 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc817fe1b14552590efd801e683686074e928570 Cr-Commit-Position: refs/heads/master@{#379721}
4 years, 9 months ago (2016-03-08 03:45:23 UTC) #10
fgorski
4 years, 9 months ago (2016-03-16 18:35:28 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1809783002/ by fgorski@chromium.org.

The reason for reverting is: https://codereview.chromium.org/1750453002 was
reverted and now the leak is happening again..

Powered by Google App Engine
This is Rietveld 408576698