Subzero: Fix symbol name mangling. Make flags global.

src/IceIntrinsics.cpp

Index: src/IceIntrinsics.cpp
diff --git a/src/IceIntrinsics.cpp b/src/IceIntrinsics.cpp
index 94e582fa083a96c0aa3480678b4de7e81905d4f2..748aeb1e37a1c79e607c4f28b1221b4776473a3a 100644
--- a/src/IceIntrinsics.cpp
+++ b/src/IceIntrinsics.cpp
@@ -236,7 +236,7 @@ const Intrinsics::FullIntrinsicInfo *Intrinsics::find(const IceString &Name,
   Error = false;
   if (Name.substr(0, LLVMPrefixLen) != LLVMPrefix)
     return nullptr;
-  IceString NameSuffix = Name.substr(LLVMPrefixLen);
+  const IceString NameSuffix = Name.substr(LLVMPrefixLen);

[John, 2016/03/06 22:39:38]

Reference?

[Jim Stichnoth, 2016/03/07 00:03:10]

std::string::substr() returns a newly constructed string object, so no?

I just added const here (and other places) for general const goodness, i.e.
NameSuffix is computed once and won't change thereafter.

[John, 2016/03/07 16:41:08]

same comment about const reference. :)

   auto it = Map.find(NameSuffix);
   if (it == Map.end()) {
     Error = true;