Subzero: Fix symbol name mangling. Make flags global.

src/IceIntrinsics.cpp

 //===- subzero/src/IceIntrinsics.cpp - Functions related to intrinsics ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 218 matching lines @@
 
 Intrinsics::~Intrinsics() = default;
 
 const Intrinsics::FullIntrinsicInfo *Intrinsics::find(const IceString &Name,
                                                       bool &Error) const {
   static const char LLVMPrefix[] = "llvm.";
   const size_t LLVMPrefixLen = strlen(LLVMPrefix);
   Error = false;
   if (Name.substr(0, LLVMPrefixLen) != LLVMPrefix)
     return nullptr;
-  IceString NameSuffix = Name.substr(LLVMPrefixLen);
+  const IceString NameSuffix = Name.substr(LLVMPrefixLen);

[John, 2016/03/06 22:39:38]

Reference?

[Jim Stichnoth, 2016/03/07 00:03:10]

std::string::substr() returns a newly constructed string object, so no?

I just added const here (and other places) for general const goodness, i.e.
NameSuffix is computed once and won't change thereafter.

[John, 2016/03/07 16:41:08]

same comment about const reference. :)

   auto it = Map.find(NameSuffix);
   if (it == Map.end()) {
     Error = true;
     return nullptr;
   }
   return &it->second;
 }
 
 namespace {
 
@@ skipping 87 matching lines @@
   return Intrinsics::IsValidCall;
 }
 
 Type Intrinsics::FullIntrinsicInfo::getArgType(SizeT Index) const {
   assert(NumTypes > 1);
   assert(Index + 1 < NumTypes);
   return Signature[Index + 1];
 }
 
 } // end of namespace Ice