Chromium Code Reviews| Index: src/IceCfg.h |
| diff --git a/src/IceCfg.h b/src/IceCfg.h |
| index 8cfe4748558a7e3c67cc1c5047d57f40cf574dfd..e48071dfa2e3d9f071744a4d7799a76e9fffadeb 100644 |
| --- a/src/IceCfg.h |
| +++ b/src/IceCfg.h |
| @@ -75,7 +75,7 @@ public: |
| /// to translate and let a fallback translator handle the function. |
| void setError(const IceString &Message); |
| bool hasError() const { return HasError; } |
| - IceString getError() const { return ErrorMessage; } |
| + const IceString &getError() const { return ErrorMessage; } |
|
John
2016/03/06 22:39:38
I understand this change, but consider this carefu
Jim Stichnoth
2016/03/07 00:03:10
You're right, no sense doing risks to optimize get
|
| /// @} |
| /// \name Manage nodes (a.k.a. basic blocks, CfgNodes). |
| @@ -225,7 +225,7 @@ public: |
| void emit(); |
| void emitIAS(); |
| - static void emitTextHeader(const IceString &MangledName, GlobalContext *Ctx, |
| + static void emitTextHeader(const IceString &Name, GlobalContext *Ctx, |
| const Assembler *Asm); |
| void dump(const IceString &Message = ""); |