Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/IceBrowserCompileServer.h

Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Cleanup Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceBrowserCompileServer.h
diff --git a/src/IceBrowserCompileServer.h b/src/IceBrowserCompileServer.h
index a9e221bcb505fe7f763c2c13c324450e8d0fd789..f870c51a07be3861e0cae01dfc9a69581bebf787 100644
--- a/src/IceBrowserCompileServer.h
+++ b/src/IceBrowserCompileServer.h
@@ -42,7 +42,9 @@ class BrowserCompileServer : public CompileServer {
class StringStream;
public:
- BrowserCompileServer() : HadError(false) {}
+ BrowserCompileServer()
+ : Flags(GlobalContext::Flags), ExtraFlags(GlobalContext::ExtraFlags),
+ HadError(false) {}
~BrowserCompileServer() final;
@@ -102,8 +104,8 @@ private:
std::unique_ptr<llvm::raw_fd_ostream> EmitStream;
std::unique_ptr<StringStream> ErrorStream;
std::unique_ptr<ELFStreamer> ELFStream;
- ClFlags Flags;
- ClFlagsExtra ExtraFlags;
+ ClFlags &Flags;
+ ClFlagsExtra &ExtraFlags;
John 2016/03/06 22:39:38 Could these be const? Otherwise, make them pointer
Jim Stichnoth 2016/03/07 00:03:10 Done.
std::thread CompileThread;
std::atomic<bool> HadError;
};

Powered by Google App Engine
This is Rietveld 408576698