Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: src/IceCfg.h

Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Cleanup Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceCfg.h
diff --git a/src/IceCfg.h b/src/IceCfg.h
index 8cfe4748558a7e3c67cc1c5047d57f40cf574dfd..e48071dfa2e3d9f071744a4d7799a76e9fffadeb 100644
--- a/src/IceCfg.h
+++ b/src/IceCfg.h
@@ -75,7 +75,7 @@ public:
/// to translate and let a fallback translator handle the function.
void setError(const IceString &Message);
bool hasError() const { return HasError; }
- IceString getError() const { return ErrorMessage; }
+ const IceString &getError() const { return ErrorMessage; }
John 2016/03/06 22:39:38 I understand this change, but consider this carefu
Jim Stichnoth 2016/03/07 00:03:10 You're right, no sense doing risks to optimize get
/// @}
/// \name Manage nodes (a.k.a. basic blocks, CfgNodes).
@@ -225,7 +225,7 @@ public:
void emit();
void emitIAS();
- static void emitTextHeader(const IceString &MangledName, GlobalContext *Ctx,
+ static void emitTextHeader(const IceString &Name, GlobalContext *Ctx,
const Assembler *Asm);
void dump(const IceString &Message = "");

Powered by Google App Engine
This is Rietveld 408576698