Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1766163002: gn format: Support # NOSORT to disable sorting of blocks (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn format: Support # NOSORT to disable sorting of blocks R=brettw@chromium.org BUG=591953 Committed: https://crrev.com/aa7f7d038156bdf3f317773b784b4a308efd0132 Cr-Commit-Position: refs/heads/master@{#380709}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M tools/gn/command_format.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/format_test_data/066.gn View 1 chunk +30 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/066.golden View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
scottmg
4 years, 9 months ago (2016-03-08 18:15:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766163002/20001
4 years, 9 months ago (2016-03-10 19:23:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 20:46:47 UTC) #5
brettw
lgtm
4 years, 9 months ago (2016-03-11 18:50:35 UTC) #6
brettw
Can this be documented in the "gn format" help?
4 years, 9 months ago (2016-03-11 18:51:21 UTC) #7
scottmg
On 2016/03/11 18:51:21, brettw wrote: > Can this be documented in the "gn format" help? ...
4 years, 9 months ago (2016-03-11 19:10:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766163002/40001
4 years, 9 months ago (2016-03-11 19:11:08 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 19:50:19 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 19:51:36 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/aa7f7d038156bdf3f317773b784b4a308efd0132
Cr-Commit-Position: refs/heads/master@{#380709}

Powered by Google App Engine
This is Rietveld 408576698