chrome/browser/lifetime/browser_close_manager_browsertest.cc - Issue 1765763002: Disable flaky BrowserCloseManagerWithBackgroundModeBrowserTest.CloseAllBrowsersWithNoOpenBrowsersWi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/browser_close_manager_browsertest.cc

Issue 1765763002: Disable flaky BrowserCloseManagerWithBackgroundModeBrowserTest.CloseAllBrowsersWithNoOpenBrowsersWi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/lifetime/browser_close_manager_browsertest.cc

diff --git a/chrome/browser/lifetime/browser_close_manager_browsertest.cc b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

index 38b0571be1650bcd293b447b077caee65726d30c..67db8a250c6044fa75830f65ccaf3b88571c5d6b 100644

--- a/chrome/browser/lifetime/browser_close_manager_browsertest.cc

+++ b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

@@ -1016,7 +1016,7 @@ IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithBackgroundModeBrowserTest,

// Check that closing all browsers with no browser windows open suspends

// background mode but does not cause Chrome to quit.

IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithBackgroundModeBrowserTest,

- CloseAllBrowsersWithNoOpenBrowsersWithBackgroundMode) {

+ DISABLED_CloseAllBrowsersWithNoOpenBrowsersWithBackgroundMode) {

RepeatedNotificationObserver close_observer(

chrome::NOTIFICATION_BROWSER_CLOSED, 1);

EXPECT_FALSE(IsBackgroundModeSuspended());

« no previous file with comments | « no previous file | no next file » | no next file with comments »