Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/lifetime/browser_close_manager_browsertest.cc

Issue 1765763002: Disable flaky BrowserCloseManagerWithBackgroundModeBrowserTest.CloseAllBrowsersWithNoOpenBrowsersWi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/lifetime/browser_close_manager.h" 5 #include "chrome/browser/lifetime/browser_close_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 browser()->window()->Close(); 1009 browser()->window()->Close();
1010 close_observer.Wait(); 1010 close_observer.Wait();
1011 EXPECT_FALSE(browser_shutdown::IsTryingToQuit()); 1011 EXPECT_FALSE(browser_shutdown::IsTryingToQuit());
1012 EXPECT_TRUE(BrowserList::GetInstance()->empty()); 1012 EXPECT_TRUE(BrowserList::GetInstance()->empty());
1013 EXPECT_FALSE(IsBackgroundModeSuspended()); 1013 EXPECT_FALSE(IsBackgroundModeSuspended());
1014 } 1014 }
1015 1015
1016 // Check that closing all browsers with no browser windows open suspends 1016 // Check that closing all browsers with no browser windows open suspends
1017 // background mode but does not cause Chrome to quit. 1017 // background mode but does not cause Chrome to quit.
1018 IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithBackgroundModeBrowserTest, 1018 IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithBackgroundModeBrowserTest,
1019 CloseAllBrowsersWithNoOpenBrowsersWithBackgroundMode) { 1019 DISABLED_CloseAllBrowsersWithNoOpenBrowsersWithBackground Mode) {
1020 RepeatedNotificationObserver close_observer( 1020 RepeatedNotificationObserver close_observer(
1021 chrome::NOTIFICATION_BROWSER_CLOSED, 1); 1021 chrome::NOTIFICATION_BROWSER_CLOSED, 1);
1022 EXPECT_FALSE(IsBackgroundModeSuspended()); 1022 EXPECT_FALSE(IsBackgroundModeSuspended());
1023 chrome::IncrementKeepAliveCount(); 1023 chrome::IncrementKeepAliveCount();
1024 browser()->window()->Close(); 1024 browser()->window()->Close();
1025 close_observer.Wait(); 1025 close_observer.Wait();
1026 EXPECT_FALSE(browser_shutdown::IsTryingToQuit()); 1026 EXPECT_FALSE(browser_shutdown::IsTryingToQuit());
1027 EXPECT_TRUE(BrowserList::GetInstance()->empty()); 1027 EXPECT_TRUE(BrowserList::GetInstance()->empty());
1028 EXPECT_FALSE(IsBackgroundModeSuspended()); 1028 EXPECT_FALSE(IsBackgroundModeSuspended());
1029 1029
1030 chrome::CloseAllBrowsers(); 1030 chrome::CloseAllBrowsers();
1031 EXPECT_FALSE(browser_shutdown::IsTryingToQuit()); 1031 EXPECT_FALSE(browser_shutdown::IsTryingToQuit());
1032 EXPECT_TRUE(BrowserList::GetInstance()->empty()); 1032 EXPECT_TRUE(BrowserList::GetInstance()->empty());
1033 EXPECT_TRUE(IsBackgroundModeSuspended()); 1033 EXPECT_TRUE(IsBackgroundModeSuspended());
1034 } 1034 }
1035 1035
1036 INSTANTIATE_TEST_CASE_P(BrowserCloseManagerWithBackgroundModeBrowserTest, 1036 INSTANTIATE_TEST_CASE_P(BrowserCloseManagerWithBackgroundModeBrowserTest,
1037 BrowserCloseManagerWithBackgroundModeBrowserTest, 1037 BrowserCloseManagerWithBackgroundModeBrowserTest,
1038 testing::Bool()); 1038 testing::Bool());
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698