Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1765673003: Remove V8.External traces due to its high overhead (Closed)

Created:
4 years, 9 months ago by fmeawad
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove V8.External traces due to its high overhead The Tracing split CL https://codereview.chromium.org/1707563002 mostly moved the location of the TRACE call, but it added 2 very high frequency calls related to tracking V8.External. In most benchmark and devices the added overhead is negligible except on N6 where it gets amplified. This CL removes those 2 calls until more efficient tracing or a different technique is used. BUG=588137 LOG=N Committed: https://crrev.com/e8dd6981ca3186c0da4e5c996396484c6064bfb9 Cr-Commit-Position: refs/heads/master@{#34499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M src/log.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/vm-state-inl.h View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765673003/1
4 years, 9 months ago (2016-03-03 23:37:20 UTC) #2
fmeawad
PTAL
4 years, 9 months ago (2016-03-03 23:37:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765673003/1
4 years, 9 months ago (2016-03-03 23:40:23 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 23:57:34 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 12:51:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765673003/1
4 years, 9 months ago (2016-03-04 14:50:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 14:52:59 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 14:54:26 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8dd6981ca3186c0da4e5c996396484c6064bfb9
Cr-Commit-Position: refs/heads/master@{#34499}

Powered by Google App Engine
This is Rietveld 408576698