Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1707563002: Split the TRACE_EVENTs from the LOG/HistogramTimers/TimerEvents functionality. (Closed)

Created:
4 years, 10 months ago by fmeawad
Modified:
4 years, 10 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split the TRACE_EVENTs from the LOG/HistogramTimers/TimerEvents functionality. This CL adds a TRACE_EVENT where there is an isolated LOG, a HistogramTimer or a TimerEvent. Once we have a d8 tracing controller, all TimerEvents will be removed since they do not provide an added value over TRACE_EVENTs. HistogramTimers will remain, but their functionality will be limited to Histograms only. BUG=v8:4562 LOG=N Committed: https://crrev.com/c6279388c75e7aad0c5d0288ac22d23c3500aefd Cr-Commit-Position: refs/heads/master@{#34099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -20 lines) Patch
M src/api.cc View 8 chunks +8 lines, -0 lines 0 comments Download
M src/compiler.cc View 10 chunks +11 lines, -0 lines 0 comments Download
M src/counters.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +7 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 16 chunks +16 lines, -0 lines 0 comments Download
M src/log.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/log-inl.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/vm-state-inl.h View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707563002/1
4 years, 10 months ago (2016-02-17 00:42:33 UTC) #2
fmeawad
PTAL
4 years, 10 months ago (2016-02-17 00:44:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11071)
4 years, 10 months ago (2016-02-17 00:57:02 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707563002/1
4 years, 10 months ago (2016-02-17 00:58:25 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 01:28:12 UTC) #12
Camillo Bruni
nice :)
4 years, 10 months ago (2016-02-17 09:03:42 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-17 10:26:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707563002/1
4 years, 10 months ago (2016-02-17 16:32:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11129)
4 years, 10 months ago (2016-02-17 16:35:59 UTC) #19
fmeawad
+adamk for parsing/parser.cc +bmeurer for ic/ic.cc and full-codegen/full-codegen.cc
4 years, 10 months ago (2016-02-17 18:23:39 UTC) #21
adamk
lgtm for parsing/
4 years, 10 months ago (2016-02-17 19:05:27 UTC) #22
Benedikt Meurer
LGTM
4 years, 10 months ago (2016-02-18 05:32:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707563002/1
4 years, 10 months ago (2016-02-18 05:38:45 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 06:12:55 UTC) #27
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 06:13:40 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6279388c75e7aad0c5d0288ac22d23c3500aefd
Cr-Commit-Position: refs/heads/master@{#34099}

Powered by Google App Engine
This is Rietveld 408576698