Stream blocks of timeline events over the service protocol

Stream blocks of timeline events over the service protocol. Can be used to monitor long running programs without buffering all events inside the VM.

- Rename TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send a 'TimelineEvents' event on the 'Timeline' stream whenever a TimelineEventBlock is finished and the 'Timeline' stream is subscribed to.

- Simple service protocol test.

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/32abe2ce550c80db520c72871552e0a114127ca9

[Cutch, 2016-03-03 19:00:44]

Description was changed from

==========
Stream Timeline events over the service protocol

BUG=
==========

to

==========
Stream Timeline events over the service protocol. Can be used to monitor long
running programs without buffering all events inside the VM. 

- Renable TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send 'TimelineEvents' events on the 'Timeline' stream a TimelineEventBlock is
finished. 

- Simple service protocol test.
==========

[Cutch, 2016-03-03 19:00:44]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[Cutch, 2016-03-03 19:01:06]

Description was changed from

==========
Stream Timeline events over the service protocol. Can be used to monitor long
running programs without buffering all events inside the VM. 

- Renable TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send 'TimelineEvents' events on the 'Timeline' stream a TimelineEventBlock is
finished. 

- Simple service protocol test.
==========

to

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM. 

- Renable TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send 'TimelineEvents' events on the 'Timeline' stream a TimelineEventBlock is
finished. 

- Simple service protocol test.
==========

[Cutch, 2016-03-03 19:01:41]

Description was changed from

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM. 

- Renable TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send 'TimelineEvents' events on the 'Timeline' stream a TimelineEventBlock is
finished. 

- Simple service protocol test.
==========

to

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM. 

- Rename TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send 'TimelineEvents' events on the 'Timeline' stream a TimelineEventBlock is
finished. 

- Simple service protocol test.
==========

[Cutch, 2016-03-03 19:02:19]

Description was changed from

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM. 

- Rename TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send 'TimelineEvents' events on the 'Timeline' stream a TimelineEventBlock is
finished. 

- Simple service protocol test.
==========

to

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM. 

- Rename TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send a 'TimelineEvents' event on the 'Timeline' stream whenever a
TimelineEventBlock is finished and the 'Timeline' stream is subscribed to.

- Simple service protocol test.
==========

[turnidge, 2016-03-03 19:18:16]

https://codereview.chromium.org/1765563002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/service_test_common.dart (right):

https://codereview.chromium.org/1765563002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/service_test_common.dart:16: Future
subscribedToStream(VM vm, String streamName, onEvent) async {
how do you feel about calling this subscribeToStream?

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service/service.md
File runtime/vm/service/service.md (right):

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.md:1130: class Event extends Response {
Document the timelineEvents property here...

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.md:1294: Extension
Add TimelineEvents here too?

The name TimelineEvents is a little funky... maybe Timeline?  Not sure.

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service_event.h
File runtime/vm/service_event.h (right):

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service_event.h#...
runtime/vm/service_event.h:208: TimelineEventBlock* timeline_event_block_;
Out of curiosity, can this be const?

[Cutch, 2016-03-03 19:43:25]

PTAL

https://codereview.chromium.org/1765563002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/service_test_common.dart (right):

https://codereview.chromium.org/1765563002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/service_test_common.dart:16: Future
subscribedToStream(VM vm, String streamName, onEvent) async {
On 2016/03/03 19:18:16, turnidge wrote:
> how do you feel about calling this subscribeToStream?

Done.

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service/service.md
File runtime/vm/service/service.md (right):

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.md:1130: class Event extends Response {
On 2016/03/03 19:18:16, turnidge wrote:
> Document the timelineEvents property here...

Done.

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.md:1294: Extension
On 2016/03/03 19:18:16, turnidge wrote:
> Add TimelineEvents here too?
> 
> The name TimelineEvents is a little funky... maybe Timeline?  Not sure.

Stuck with TimelineEvents.

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service_event.h
File runtime/vm/service_event.h (right):

https://codereview.chromium.org/1765563002/diff/1/runtime/vm/service_event.h#...
runtime/vm/service_event.h:208: TimelineEventBlock* timeline_event_block_;
On 2016/03/03 19:18:16, turnidge wrote:
> Out of curiosity, can this be const?

Done.

[turnidge, 2016-03-04 20:25:45]

lgtm

[Cutch, 2016-03-04 20:30:55]

Description was changed from

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM. 

- Rename TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send a 'TimelineEvents' event on the 'Timeline' stream whenever a
TimelineEventBlock is finished and the 'Timeline' stream is subscribed to.

- Simple service protocol test.
==========

to

==========
Stream blocks of timeline events over the service protocol. Can be used to
monitor long running programs without buffering all events inside the VM.

- Rename TimelineEventStreamingRecorder to TimelineEventCallbackRecorder. Note
that this should only be used for tests.

- Add 'Timeline' service event stream.
- Send a 'TimelineEvents' event on the 'Timeline' stream whenever a
TimelineEventBlock is finished and the 'Timeline' stream is subscribed to.

- Simple service protocol test.

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/32abe2ce550c80db520c72871552e0a114127ca9
==========

[Cutch, 2016-03-04 20:30:56]

Committed patchset #2 (id:20001) manually as
32abe2ce550c80db520c72871552e0a114127ca9 (presubmit successful).