Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: runtime/vm/json_stream.h

Issue 1765563002: Stream blocks of timeline events over the service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/vm_timeline_events_test.dart ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/json_stream.h
diff --git a/runtime/vm/json_stream.h b/runtime/vm/json_stream.h
index 8c145681263de23ada70bb6323621bc8930f74a0..6c4f23e32bc1c0b5d804ff44714cec95935cf205 100644
--- a/runtime/vm/json_stream.h
+++ b/runtime/vm/json_stream.h
@@ -29,6 +29,7 @@ class Script;
class ServiceEvent;
class String;
class TimelineEvent;
+class TimelineEventBlock;
class Zone;
@@ -162,7 +163,8 @@ class JSONStream : ValueObject {
void PrintValue(MessageQueue* queue);
void PrintValue(Isolate* isolate, bool ref = true);
bool PrintValueStr(const String& s, intptr_t offset, intptr_t count);
- void PrintValue(TimelineEvent* timeline_event);
+ void PrintValue(const TimelineEvent* timeline_event);
+ void PrintValue(const TimelineEventBlock* timeline_event_block);
void PrintValueVM(bool ref = true);
void PrintServiceId(const Object& o);
@@ -189,7 +191,9 @@ class JSONStream : ValueObject {
void PrintProperty(const char* name, Metric* metric);
void PrintProperty(const char* name, MessageQueue* queue);
void PrintProperty(const char* name, Isolate* isolate);
- void PrintProperty(const char* name, TimelineEvent* timeline_event);
+ void PrintProperty(const char* name, const TimelineEvent* timeline_event);
+ void PrintProperty(const char* name,
+ const TimelineEventBlock* timeline_event_block);
void PrintPropertyVM(const char* name, bool ref = true);
void PrintPropertyName(const char* name);
void PrintCommaIfNeeded();
@@ -309,9 +313,14 @@ class JSONObject : public ValueObject {
void AddProperty(const char* name, Isolate* isolate) const {
stream_->PrintProperty(name, isolate);
}
- void AddProperty(const char* name, TimelineEvent* timeline_event) const {
+ void AddProperty(const char* name,
+ const TimelineEvent* timeline_event) const {
stream_->PrintProperty(name, timeline_event);
}
+ void AddProperty(const char* name,
+ const TimelineEventBlock* timeline_event_block) const {
+ stream_->PrintProperty(name, timeline_event_block);
+ }
void AddPropertyVM(const char* name, bool ref = true) const {
stream_->PrintPropertyVM(name, ref);
}
@@ -376,9 +385,12 @@ class JSONArray : public ValueObject {
void AddValue(MessageQueue* queue) const {
stream_->PrintValue(queue);
}
- void AddValue(TimelineEvent* timeline_event) const {
+ void AddValue(const TimelineEvent* timeline_event) const {
stream_->PrintValue(timeline_event);
}
+ void AddValue(const TimelineEventBlock* timeline_event_block) const {
+ stream_->PrintValue(timeline_event_block);
+ }
void AddValueVM(bool ref = true) const {
stream_->PrintValueVM(ref);
}
« no previous file with comments | « runtime/observatory/tests/service/vm_timeline_events_test.dart ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698