Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1765493002: Revert of Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
kinuko, sof
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+worker_chromium.org, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (patchset #3 id:40001 of https://codereview.chromium.org/1744973002/ ) Reason for revert: I noticed that we're not ready to remove the m_stopped variable (because LifecycleObserver does not yet have an ability to clear LifecycleObserver::m_context when the context is destroyed). We need to fix the LifecycleObserver before landing this fix. Original issue's description: > Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject > > Per the plan described in https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discussion, > this CL reduces ActiveDOMObjects in the code base. > > - This CL replaces ServiceWorker::m_wasStopped with ContextLifecycleObserver::executionContext(). > > - This CL removes an 'if(AbstractWorker::hasPendingActivity)' check because it always returns true. > > BUG=589507 > > Committed: https://crrev.com/21ab87586c14afb2a22c91b05d932563cba9569d > Cr-Commit-Position: refs/heads/master@{#378332} TBR=kinuko@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589507 Committed: https://crrev.com/99ccb8b5651202f197625695d87bd548ef94aeab Cr-Commit-Position: refs/heads/master@{#378997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M third_party/WebKit/Source/core/workers/AbstractWorker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/AbstractWorker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
haraken
Created Revert of Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject
4 years, 9 months ago (2016-03-03 10:05:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765493002/1
4 years, 9 months ago (2016-03-03 10:05:56 UTC) #2
sof
lgtm
4 years, 9 months ago (2016-03-03 10:06:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765493002/1
4 years, 9 months ago (2016-03-03 10:31:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765493002/1
4 years, 9 months ago (2016-03-03 11:01:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 11:20:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99ccb8b5651202f197625695d87bd548ef94aeab Cr-Commit-Position: refs/heads/master@{#378997}
4 years, 9 months ago (2016-03-03 11:22:18 UTC) #9
Finnur
Also, it seems a lot of the service worker tests went green as a result ...
4 years, 9 months ago (2016-03-03 15:16:04 UTC) #10
kinuko
4 years, 9 months ago (2016-03-07 02:21:53 UTC) #11
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698