DescriptionRevert of Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (patchset #3 id:40001 of https://codereview.chromium.org/1744973002/ )
Reason for revert:
I noticed that we're not ready to remove the m_stopped variable (because
LifecycleObserver does not yet have an ability to clear
LifecycleObserver::m_context when the context is destroyed). We need to fix the
LifecycleObserver before landing this fix.
Original issue's description:
> Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject
>
> Per the plan described in https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discussion,
> this CL reduces ActiveDOMObjects in the code base.
>
> - This CL replaces ServiceWorker::m_wasStopped with ContextLifecycleObserver::executionContext().
>
> - This CL removes an 'if(AbstractWorker::hasPendingActivity)' check because it always returns true.
>
> BUG=589507
>
> Committed: https://crrev.com/21ab87586c14afb2a22c91b05d932563cba9569d
> Cr-Commit-Position: refs/heads/master@{#378332}
TBR=kinuko@chromium.org,sigbjornf@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=589507
Committed: https://crrev.com/99ccb8b5651202f197625695d87bd548ef94aeab
Cr-Commit-Position: refs/heads/master@{#378997}
Patch Set 1 #
Messages
Total messages: 11 (2 generated)
|