Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

Issue 1765493002: Revert of Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 } 104 }
105 } 105 }
106 106
107 ServiceWorker* ServiceWorker::from(ExecutionContext* executionContext, PassOwnPt r<WebServiceWorker::Handle> handle) 107 ServiceWorker* ServiceWorker::from(ExecutionContext* executionContext, PassOwnPt r<WebServiceWorker::Handle> handle)
108 { 108 {
109 return getOrCreate(executionContext, handle); 109 return getOrCreate(executionContext, handle);
110 } 110 }
111 111
112 bool ServiceWorker::hasPendingActivity() const 112 bool ServiceWorker::hasPendingActivity() const
113 { 113 {
114 if (!executionContext()) 114 if (AbstractWorker::hasPendingActivity())
115 return true;
116 if (m_wasStopped)
115 return false; 117 return false;
116 return m_handle->serviceWorker()->state() != WebServiceWorkerStateRedundant; 118 return m_handle->serviceWorker()->state() != WebServiceWorkerStateRedundant;
117 } 119 }
118 120
121 void ServiceWorker::stop()
122 {
123 m_wasStopped = true;
124 }
125
119 ServiceWorker* ServiceWorker::getOrCreate(ExecutionContext* executionContext, Pa ssOwnPtr<WebServiceWorker::Handle> handle) 126 ServiceWorker* ServiceWorker::getOrCreate(ExecutionContext* executionContext, Pa ssOwnPtr<WebServiceWorker::Handle> handle)
120 { 127 {
121 if (!handle) 128 if (!handle)
122 return nullptr; 129 return nullptr;
123 130
124 ServiceWorker* existingWorker = static_cast<ServiceWorker*>(handle->serviceW orker()->proxy()); 131 ServiceWorker* existingWorker = static_cast<ServiceWorker*>(handle->serviceW orker()->proxy());
125 if (existingWorker) { 132 if (existingWorker) {
126 ASSERT(existingWorker->executionContext() == executionContext); 133 ASSERT(existingWorker->executionContext() == executionContext);
127 return existingWorker; 134 return existingWorker;
128 } 135 }
129 136
130 return new ServiceWorker(executionContext, handle); 137 ServiceWorker* newWorker = new ServiceWorker(executionContext, handle);
138 newWorker->suspendIfNeeded();
139 return newWorker;
131 } 140 }
132 141
133 ServiceWorker::ServiceWorker(ExecutionContext* executionContext, PassOwnPtr<WebS erviceWorker::Handle> handle) 142 ServiceWorker::ServiceWorker(ExecutionContext* executionContext, PassOwnPtr<WebS erviceWorker::Handle> handle)
134 : AbstractWorker(executionContext) 143 : AbstractWorker(executionContext)
135 , m_handle(handle) 144 , m_handle(handle)
145 , m_wasStopped(false)
136 { 146 {
137 ASSERT(m_handle); 147 ASSERT(m_handle);
138 m_handle->serviceWorker()->setProxy(this); 148 m_handle->serviceWorker()->setProxy(this);
139 } 149 }
140 150
141 ServiceWorker::~ServiceWorker() 151 ServiceWorker::~ServiceWorker()
142 { 152 {
143 } 153 }
144 154
145 } // namespace blink 155 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698