Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Issue 1765483002: [tools/perf] Skip try job run if trybot config file does not change (Closed)

Created:
4 years, 9 months ago by nednguyen
Modified:
4 years, 9 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Skip try job run if trybot config file does not change Sometime, users run trybot job against many bots of different platforms (e.g: platforms win & winx64). Sometimes the configs of these different platforms are the same because they happens to share the same bot. In this case, we will skip the trybot run if the config file does not change. BUG=591613 Committed: https://crrev.com/91da72fe17e3d7466c36f9b1f6a07998516a3264 Cr-Commit-Position: refs/heads/master@{#378979}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M tools/perf/core/trybot_command.py View 2 chunks +15 lines, -6 lines 2 comments Download
M tools/perf/core/trybot_command_unittest.py View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
nednguyen
4 years, 9 months ago (2016-03-03 06:29:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765483002/1
4 years, 9 months ago (2016-03-03 06:29:46 UTC) #5
sullivan
lgtm https://codereview.chromium.org/1765483002/diff/1/tools/perf/core/trybot_command.py File tools/perf/core/trybot_command.py (right): https://codereview.chromium.org/1765483002/diff/1/tools/perf/core/trybot_command.py#newcode405 tools/perf/core/trybot_command.py:405: else: Shouldn't this use logging api?
4 years, 9 months ago (2016-03-03 06:31:59 UTC) #6
nednguyen
https://codereview.chromium.org/1765483002/diff/1/tools/perf/core/trybot_command.py File tools/perf/core/trybot_command.py (right): https://codereview.chromium.org/1765483002/diff/1/tools/perf/core/trybot_command.py#newcode405 tools/perf/core/trybot_command.py:405: else: On 2016/03/03 06:31:59, sullivan wrote: > Shouldn't this ...
4 years, 9 months ago (2016-03-03 06:52:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765483002/1
4 years, 9 months ago (2016-03-03 06:52:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 07:56:00 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 07:57:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91da72fe17e3d7466c36f9b1f6a07998516a3264
Cr-Commit-Position: refs/heads/master@{#378979}

Powered by Google App Engine
This is Rietveld 408576698