[tools/perf] Skip try job run if trybot config file does not change

tools/perf/core/trybot_command_unittest.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import argparse
 import logging
 import json
 import StringIO
 import unittest
 
 import mock
@@ skipping 37 matching lines @@
     self._stubs.Restore()
     self._subprocess_patcher.stop()
     self._urllib2_patcher.stop()
     # Reset the cached builders in trybot_command
     trybot_command.Trybot._builders = None
 
   def _ExpectProcesses(self, expected_args_list):
     counter = [-1]
 
     def side_effect(args, **kwargs):
+      if not expected_args_list:
+        self.fail(
+            'Not expect any Popen() call but got a Popen call with %s\n' % args)
       del kwargs  # unused
       counter[0] += 1
       expected_args, expected_responses = expected_args_list[counter[0]]
       self.assertEquals(
           expected_args, args,
           'Popen() is called with unexpected args.\n Actual: %s.\n'
           'Expecting (index %i): %s' % (args, counter[0], expected_args))
       return FakeProcess(expected_responses)
     self._mock_subprocess.Popen.side_effect = side_effect
 
@@ skipping 412 matching lines @@
          (0, 'stuff https://codereview.chromium.org/12345 stuff', None)),
         (['git', 'cl', 'try', '-m', 'tryserver.chromium.perf', '-b',
           'android_nexus4_perf_bisect'], (128, None, None))))
     cfg_filename = 'tools/run-perf-test.cfg'
     cfg = StringIO.StringIO()
     self._stubs.open.files = {cfg_filename: cfg}
     self.assertRaises(
         trybot_command.TrybotError, command._UpdateConfigAndRunTryjob,
         'android', cfg_filename, [])
 
+  def testUpdateConfigSkipTryjob(self):
+    self._MockTryserverJson({'win_perf_bisect': 'stuff'})
+    command = trybot_command.Trybot()
+    command._InitializeBuilderNames('win-x64')
+    self._ExpectProcesses(())
+    cfg_filename = 'tools/run-perf-test.cfg'
+    cfg_data = '''config = {
+  "command": "python tools\\\\perf\\\\run_benchmark --browser=release_x64",
+  "max_time_minutes": "120",
+  "repeat_count": "1",
+  "target_arch": "x64",
+  "truncate_percent": "0"
+}'''
+    self._stubs.open.files = {cfg_filename: cfg_data}
+    self.assertEquals((trybot_command.NO_CHANGES, ''),
+                      command._UpdateConfigAndRunTryjob(
+                          'win-x64', cfg_filename, []))
+
   def testUpdateConfigGitTry(self):
     self._MockTryserverJson({'android_nexus4_perf_bisect': 'stuff'})
     command = trybot_command.Trybot()
     command._InitializeBuilderNames('android-nexus4')
     self._ExpectProcesses((
         (['git', 'commit', '-a', '-m', 'bisect config: android'],
          (0, 'None', None)),
         (['git', 'cl', 'upload', '-f', '--bypass-hooks', '-m',
           'CL for perf tryjob on android'],
          (0, 'stuff https://codereview.chromium.org/12345 stuff', None)),
@@ skipping 70 matching lines @@
   "target_arch": "ia32",
   "truncate_percent": "0"
 }''''''config = {
   "command": "./tools/perf/run_benchmark --browser=android-chromium",
   "max_time_minutes": "120",
   "repeat_count": "1",
   "target_arch": "ia32",
   "truncate_percent": "0"
 }''')
     self.assertEquals(cfg.read(), config)