Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: chrome/browser/media/router/media_router_metrics_unittest.cc

Issue 1765143002: [Media Router] Add UMA histograms tracking component extension version/wakeups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to isherman@ comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_metrics_unittest.cc
diff --git a/chrome/browser/media/router/media_router_metrics_unittest.cc b/chrome/browser/media/router/media_router_metrics_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..722a656341c5b6a476630c4d94588eaa0d35fff6
--- /dev/null
+++ b/chrome/browser/media/router/media_router_metrics_unittest.cc
@@ -0,0 +1,40 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/media_router_metrics.h"
+
+#include <limits.h>
+
+#include "base/version.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media_router {
+
+TEST(MediaRouteProviderMetricsTest, TestGetVersionDifference) {
+ base::Version second("50.0.2396.71");
Wez 2016/03/18 18:35:43 nit: const base::Version kVersionForTest, say? - |
mark a. foltz 2016/03/18 20:11:00 Done.
+ EXPECT_EQ(0, MediaRouterMetrics::GetVersionDifference(
+ base::Version("50.0.2396.71"), second));
+ EXPECT_EQ(0, MediaRouterMetrics::GetVersionDifference(
+ base::Version("50.0.2100.0"), second));
+ EXPECT_EQ(1, MediaRouterMetrics::GetVersionDifference(
+ base::Version("51.0.2117.0"), second));
+ EXPECT_EQ(-1, MediaRouterMetrics::GetVersionDifference(
+ base::Version("49.0.2138.0"), second));
+ EXPECT_EQ(-3, MediaRouterMetrics::GetVersionDifference(
+ base::Version("47.0.1134.0"), second));
+ EXPECT_EQ(std::numeric_limits<int>::min(),
+ MediaRouterMetrics::GetVersionDifference(base::Version("blargh"),
+ second));
+ EXPECT_EQ(
+ std::numeric_limits<int>::min(),
+ MediaRouterMetrics::GetVersionDifference(base::Version(""), second));
+ EXPECT_EQ(std::numeric_limits<int>::min(),
+ MediaRouterMetrics::GetVersionDifference(base::Version("-1.0.0.0"),
+ second));
+ EXPECT_EQ(
+ std::numeric_limits<int>::min(),
+ MediaRouterMetrics::GetVersionDifference(base::Version("0"), second));
+}
+
+} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698