Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/media/router/media_router_metrics_unittest.cc

Issue 1765143002: [Media Router] Add UMA histograms tracking component extension version/wakeups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to isherman@ comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/media/router/media_router_metrics.h"
6
7 #include <limits.h>
8
9 #include "base/version.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11
12 namespace media_router {
13
14 TEST(MediaRouteProviderMetricsTest, TestGetVersionDifference) {
15 base::Version second("50.0.2396.71");
Wez 2016/03/18 18:35:43 nit: const base::Version kVersionForTest, say? - |
mark a. foltz 2016/03/18 20:11:00 Done.
16 EXPECT_EQ(0, MediaRouterMetrics::GetVersionDifference(
17 base::Version("50.0.2396.71"), second));
18 EXPECT_EQ(0, MediaRouterMetrics::GetVersionDifference(
19 base::Version("50.0.2100.0"), second));
20 EXPECT_EQ(1, MediaRouterMetrics::GetVersionDifference(
21 base::Version("51.0.2117.0"), second));
22 EXPECT_EQ(-1, MediaRouterMetrics::GetVersionDifference(
23 base::Version("49.0.2138.0"), second));
24 EXPECT_EQ(-3, MediaRouterMetrics::GetVersionDifference(
25 base::Version("47.0.1134.0"), second));
26 EXPECT_EQ(std::numeric_limits<int>::min(),
27 MediaRouterMetrics::GetVersionDifference(base::Version("blargh"),
28 second));
29 EXPECT_EQ(
30 std::numeric_limits<int>::min(),
31 MediaRouterMetrics::GetVersionDifference(base::Version(""), second));
32 EXPECT_EQ(std::numeric_limits<int>::min(),
33 MediaRouterMetrics::GetVersionDifference(base::Version("-1.0.0.0"),
34 second));
35 EXPECT_EQ(
36 std::numeric_limits<int>::min(),
37 MediaRouterMetrics::GetVersionDifference(base::Version("0"), second));
38 }
39
40 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698