Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1765083003: Remove idealsvdr.com from the HSTS preload list. (Closed)

Created:
4 years, 9 months ago by lgarron
Modified:
4 years, 9 months ago
Reviewers:
palmer
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove idealsvdr.com from the HSTS preload list. Reason given: "Unfortunately, we have two 3rd-party services linked over cnames [...] that cannot be used over https as their 3rd party certificates [...] do not include our domain." BUG=527947 Committed: https://crrev.com/97d372c2bc6233832ee573db666579ea15209430 Cr-Commit-Position: refs/heads/master@{#379961}

Patch Set 1 #

Patch Set 2 : Add header. #

Patch Set 3 : #

Patch Set 4 : Add .h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6295 lines, -6160 lines) Patch
M net/http/transport_security_state_static.h View 1 2 3 4 chunks +6295 lines, -6159 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765083003/1
4 years, 9 months ago (2016-03-04 22:54:35 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-04 22:54:36 UTC) #4
lgarron
palmer@, would you like to do the honors? (In the future, I'll probably just TBR= ...
4 years, 9 months ago (2016-03-04 22:56:04 UTC) #7
lgarron
I can't get the .h file to upload. Will look at it next week. Using ...
4 years, 9 months ago (2016-03-04 23:25:09 UTC) #8
lgarron
So, it turns out that the diff for transport_security_state_static.h is now too large to upload. ...
4 years, 9 months ago (2016-03-07 18:36:59 UTC) #9
lgarron
palmer@, could you review now? I've temporarily hacked around the upload limit by changing MAX_UPLOAD_SIZE ...
4 years, 9 months ago (2016-03-07 18:53:00 UTC) #10
lgarron
paklmer@: ping
4 years, 9 months ago (2016-03-08 20:56:03 UTC) #11
palmer
LGTM. Wow, the upload script didn't print a meaningful error? Seems like you should either ...
4 years, 9 months ago (2016-03-08 22:00:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765083003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765083003/30001
4 years, 9 months ago (2016-03-08 22:03:47 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:30001)
4 years, 9 months ago (2016-03-08 23:17:16 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 23:24:24 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/97d372c2bc6233832ee573db666579ea15209430
Cr-Commit-Position: refs/heads/master@{#379961}

Powered by Google App Engine
This is Rietveld 408576698