Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.h

Issue 1764913003: BlankText UMAs should be reported only for webfonts in block period (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
index c9102ffe52a50e137eb0c11df78cd2598e0a0197..92582ea58243b9b61b7b77a69a93d1f816b0a2c9 100644
--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
@@ -46,7 +46,7 @@ public:
// For UMA reporting
bool hadBlankText() override { return m_histograms.hadBlankText(); }
- void paintRequested() { m_histograms.fallbackFontPainted(); }
+ void paintRequested() { m_histograms.fallbackFontPainted(m_period); }
DECLARE_VIRTUAL_TRACE();
@@ -59,19 +59,19 @@ private:
class FontLoadHistograms {
DISALLOW_NEW();
public:
- FontLoadHistograms() : m_loadStartTime(0), m_fallbackPaintTime(0), m_isLongLimitExceeded(false) { }
+ FontLoadHistograms() : m_loadStartTime(0), m_blankPaintTime(0), m_isLongLimitExceeded(false) { }
void loadStarted();
- void fallbackFontPainted();
+ void fallbackFontPainted(DisplayPeriod);
void fontLoaded(bool isInterventionTriggered);
void longLimitExceeded(bool isInterventionTriggered);
void recordFallbackTime(const FontResource*);
void recordRemoteFont(const FontResource*);
- bool hadBlankText() { return m_fallbackPaintTime; }
+ bool hadBlankText() { return m_blankPaintTime; }
private:
void recordLoadTimeHistogram(const FontResource*, int duration);
void recordInterventionResult(bool triggered);
double m_loadStartTime;
- double m_fallbackPaintTime;
+ double m_blankPaintTime;
bool m_isLongLimitExceeded;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698