Enable offline pages feature on trunk by default

Enable offline pages feature on trunk by default

BUG=592718
Committed: https://crrev.com/364f4ef0f205967019fbb0b55f0bbb96ab76ad7d
Cr-Commit-Position: refs/heads/master@{#379639}

[jianli, 2016-03-04 00:25:30]

jianli@chromium.org changed reviewers:
+ dimich@chromium.org

[Dmitry Titov, 2016-03-04 01:33:10]

https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:289: // fully loaded. If so, just
bail out since this is most likely due to tests.
lets change the comment as discussed.

[jianli, 2016-03-04 02:01:07]

https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.cc:289: // fully loaded. If so, just
bail out since this is most likely due to tests.
On 2016/03/04 01:33:10, Dmitry Titov wrote:
> lets change the comment as discussed.

Done.

[Dmitry Titov, 2016-03-04 02:26:38]

lgtm

[jianli, 2016-03-04 21:15:14]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2016-03-04 21:15:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764843003/20001

[commit-bot: I haz the power, 2016-03-04 21:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 21:25:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2016-03-04 21:32:42]

jianli@chromium.org changed reviewers:
+ jochen@chromium.org

[jianli, 2016-03-04 21:32:43]

jochen, could you please review DEPS change on version_info? Thanks.

[jochen (gone - plz use gerrit), 2016-03-07 11:57:25]

tracking bug please

[Dmitry Titov, 2016-03-07 18:09:41]

http://crbug.com/458502

[jochen (gone - plz use gerrit), 2016-03-07 18:16:39]

On 2016/03/07 at 18:09:41, dimich wrote:
> http://crbug.com/458502

sorry, for being unclear. I meant "Please reference the tracking bug in the CL
description".

I've put it there for you, so lgtm

[jochen (gone - plz use gerrit), 2016-03-07 18:16:49]

Description was changed from

==========
Enable offline pages feature on trunk by default

BUG=none
==========

to

==========
Enable offline pages feature on trunk by default

BUG=458502
==========

[jianli, 2016-03-07 20:06:46]

On 2016/03/07 18:16:39, jochen wrote:
> On 2016/03/07 at 18:09:41, dimich wrote:
> > http://crbug.com/458502
> 
> sorry, for being unclear. I meant "Please reference the tracking bug in the CL
> description".
> 
> I've put it there for you, so lgtm

458502 indeed is a launch tracking bug and normally we will not add CLs to it. I
will open a new one and update the description.

[jianli, 2016-03-07 20:08:23]

Description was changed from

==========
Enable offline pages feature on trunk by default

BUG=458502
==========

to

==========
Enable offline pages feature on trunk by default

BUG=592718
==========

[jianli, 2016-03-07 20:08:32]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2016-03-07 20:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764843003/20001

[commit-bot: I haz the power, 2016-03-07 21:04:24]

Description was changed from

==========
Enable offline pages feature on trunk by default

BUG=592718
==========

to

==========
Enable offline pages feature on trunk by default

BUG=592718
==========

[commit-bot: I haz the power, 2016-03-07 21:04:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 21:06:52]

Description was changed from

==========
Enable offline pages feature on trunk by default

BUG=592718
==========

to

==========
Enable offline pages feature on trunk by default

BUG=592718

Committed: https://crrev.com/364f4ef0f205967019fbb0b55f0bbb96ab76ad7d
Cr-Commit-Position: refs/heads/master@{#379639}
==========

[commit-bot: I haz the power, 2016-03-07 21:06:53]

Patchset 2 (id:??) landed as
https://crrev.com/364f4ef0f205967019fbb0b55f0bbb96ab76ad7d
Cr-Commit-Position: refs/heads/master@{#379639}