Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1764843003: Enable offline pages feature on trunk by default (Closed)

Created:
4 years, 9 months ago by jianli
Modified:
4 years, 9 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable offline pages feature on trunk by default BUG=592718 Committed: https://crrev.com/364f4ef0f205967019fbb0b55f0bbb96ab76ad7d Cr-Commit-Position: refs/heads/master@{#379639}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/offline_pages/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/offline_page_feature.cc View 2 chunks +5 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
jianli
4 years, 9 months ago (2016-03-04 00:25:30 UTC) #2
Dmitry Titov
https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/offline_page_model.cc File components/offline_pages/offline_page_model.cc (right): https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/offline_page_model.cc#newcode289 components/offline_pages/offline_page_model.cc:289: // fully loaded. If so, just bail out since ...
4 years, 9 months ago (2016-03-04 01:33:10 UTC) #3
jianli
https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/offline_page_model.cc File components/offline_pages/offline_page_model.cc (right): https://codereview.chromium.org/1764843003/diff/1/components/offline_pages/offline_page_model.cc#newcode289 components/offline_pages/offline_page_model.cc:289: // fully loaded. If so, just bail out since ...
4 years, 9 months ago (2016-03-04 02:01:07 UTC) #4
Dmitry Titov
lgtm
4 years, 9 months ago (2016-03-04 02:26:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764843003/20001
4 years, 9 months ago (2016-03-04 21:15:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/153540)
4 years, 9 months ago (2016-03-04 21:25:42 UTC) #9
jianli
jochen, could you please review DEPS change on version_info? Thanks.
4 years, 9 months ago (2016-03-04 21:32:43 UTC) #11
jochen (gone - plz use gerrit)
tracking bug please
4 years, 9 months ago (2016-03-07 11:57:25 UTC) #12
Dmitry Titov
http://crbug.com/458502
4 years, 9 months ago (2016-03-07 18:09:41 UTC) #13
jochen (gone - plz use gerrit)
On 2016/03/07 at 18:09:41, dimich wrote: > http://crbug.com/458502 sorry, for being unclear. I meant "Please ...
4 years, 9 months ago (2016-03-07 18:16:39 UTC) #14
jianli
On 2016/03/07 18:16:39, jochen wrote: > On 2016/03/07 at 18:09:41, dimich wrote: > > http://crbug.com/458502 ...
4 years, 9 months ago (2016-03-07 20:06:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764843003/20001
4 years, 9 months ago (2016-03-07 20:09:04 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 21:04:25 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 21:06:53 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/364f4ef0f205967019fbb0b55f0bbb96ab76ad7d
Cr-Commit-Position: refs/heads/master@{#379639}

Powered by Google App Engine
This is Rietveld 408576698