Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: components/offline_pages/offline_page_feature.cc

Issue 1764843003: Enable offline pages feature on trunk by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/DEPS ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_feature.cc
diff --git a/components/offline_pages/offline_page_feature.cc b/components/offline_pages/offline_page_feature.cc
index beee145d8398d9618a126bcad5070aa3bbb0039c..ed390b8815e0abe9990d76c5fa0f1bfefbb11ebb 100644
--- a/components/offline_pages/offline_page_feature.cc
+++ b/components/offline_pages/offline_page_feature.cc
@@ -11,6 +11,7 @@
#include "base/strings/string_util.h"
#include "build/build_config.h"
#include "components/offline_pages/offline_page_switches.h"
+#include "components/version_info/version_info.h"
#if defined(OS_ANDROID)
@@ -62,7 +63,10 @@ FeatureMode GetOfflinePageFeatureMode() {
base::CompareCase::SENSITIVE)) {
return FeatureMode::ENABLED_AS_SAVED_PAGES;
}
- return FeatureMode::DISABLED;
+
+ // Enabled by default on trunk.
+ return version_info::IsOfficialBuild() ? FeatureMode::DISABLED
+ : FeatureMode::ENABLED_AS_BOOKMARKS;
}
bool IsOfflinePagesEnabled() {
« no previous file with comments | « components/offline_pages/DEPS ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698