Move files under webkit/browser/fileapi/... to chrome/browser/chromeos/fileapi/...

Move files under webkit/browser/fileapi/... to chrome/browser/chromeos/fileapi/...

To isolate files only for chromeos from webkit/... directory, this CL moves the
files to chrome/browser/chromeos/fileapi/... directory.
Along with the moving, moved RemoteFileStreamWriter from fileapi namespace
to chromeos namespace.
webkit/browser/chromeos/fileapi/async_file_stream.h is not used at all, so it is just removed.


BUG=242423
TEST=Ran unit_tests and tested manually on chrome os.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208664

[hidehiko, 2013-06-25 05:23:16]

This is based on 17637006.
Thank you for your review in advance,
- hidehiko

[kinuko, 2013-06-25 07:07:02]

webkit/ changes lgtm, can you run try jobs?

https://codereview.chromium.org/17644006/diff/1037/chrome/browser/chrome_cont...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/17644006/diff/1037/chrome/browser/chrome_cont...
chrome/browser/chrome_content_browser_client.cc:2257: external_mount_points,
I wonder it might work nicer if GetAdditionalFileSystemMountPointProviders takes
BrowserContext and we get BrowserContext::GetMountPoints(context) here? (It's
not necessarily be considered in this patch though)

https://codereview.chromium.org/17644006/diff/1037/chrome/chrome_browser_chro...
File chrome/chrome_browser_chromeos.gypi (right):

https://codereview.chromium.org/17644006/diff/1037/chrome/chrome_browser_chro...
chrome/chrome_browser_chromeos.gypi:334:
'browser/chromeos/fileapi/file_util_async.h',
This file may not exist?

[hidehiko, 2013-06-25 08:10:02]

Thank you for your quick review. PTAL?

I ran try job with patch-set1, which includes 17637006 currently in CQ.

https://codereview.chromium.org/17644006/diff/1037/chrome/browser/chrome_cont...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/17644006/diff/1037/chrome/browser/chrome_cont...
chrome/browser/chrome_content_browser_client.cc:2257: external_mount_points,
On 2013/06/25 07:07:02, kinuko wrote:
> I wonder it might work nicer if GetAdditionalFileSystemMountPointProviders
takes
> BrowserContext and we get BrowserContext::GetMountPoints(context) here? (It's
> not necessarily be considered in this patch though)

I agree with you that it'd be nicer. Actually, we are talking about removing
RemoveFileSystemProxy, which is designed only for accessing drive file system
from webkit/... files, and BrowserContext will be needed for it.
Please let me work on it in another CL in order to focus on moving chromeos
related files in this CL.

https://codereview.chromium.org/17644006/diff/1037/chrome/chrome_browser_chro...
File chrome/chrome_browser_chromeos.gypi (right):

https://codereview.chromium.org/17644006/diff/1037/chrome/chrome_browser_chro...
chrome/chrome_browser_chromeos.gypi:334:
'browser/chromeos/fileapi/file_util_async.h',
On 2013/06/25 07:07:02, kinuko wrote:
> This file may not exist?

Good catch. Removed.

[kinuko, 2013-06-25 10:06:31]

still lgtm

[kinaba, 2013-06-25 10:46:42]

lgtm

[hidehiko, 2013-06-25 11:19:38]

Thank you for your review, Kinuko, Kazuhiro.

+avi@.
Avi, could you review the content/ related files as an OWNER?
I'd appreciate your help.

- hidehiko

[Avi (use Gerrit), 2013-06-25 14:41:32]

lgtm

[satorux1, 2013-06-25 20:30:06]

LGTM with nits

https://codereview.chromium.org/17644006/diff/28001/chrome/browser/chrome_con...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/17644006/diff/28001/chrome/browser/chrome_con...
chrome/browser/chrome_content_browser_client.cc:2261:
DCHECK(cros_mount_provider->CanHandleType(fileapi::kFileSystemTypeExternal));
nit: swap lines 2260 and 2261?

https://codereview.chromium.org/17644006/diff/28001/content/public/browser/co...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/17644006/diff/28001/content/public/browser/co...
content/public/browser/content_browser_client.h:538: // Returns additional
MountPointProviders for FileSystem API.
Please add descriptions for the new parameters. why these are necessary?

[hidehiko, 2013-06-26 04:31:35]

Thank you for your review. Sending to CQ.

https://codereview.chromium.org/17644006/diff/28001/chrome/browser/chrome_con...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/17644006/diff/28001/chrome/browser/chrome_con...
chrome/browser/chrome_content_browser_client.cc:2261:
DCHECK(cros_mount_provider->CanHandleType(fileapi::kFileSystemTypeExternal));
On 2013/06/25 20:30:06, satorux1 wrote:
> nit: swap lines 2260 and 2261?

Done.

https://codereview.chromium.org/17644006/diff/28001/content/public/browser/co...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/17644006/diff/28001/content/public/browser/co...
content/public/browser/content_browser_client.h:538: // Returns additional
MountPointProviders for FileSystem API.
On 2013/06/25 20:30:06, satorux1 wrote:
> Please add descriptions for the new parameters. why these are necessary?

Done.

[commit-bot: I haz the power, 2013-06-26 04:32:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/17644006/38001

[commit-bot: I haz the power, 2013-06-26 08:13:36]

Change committed as 208664