Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1764253002: Rename shell.mojom to connector.mojom, ApplicationManager to Shell (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@32exe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename shell.mojom to connector.mojom and ApplicationManager to Shell TBR=sky@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/15b9a8b847fe280eb141897ea4f0a60fa1060476 Cr-Commit-Position: refs/heads/master@{#379459}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -1748 lines) Patch
M components/mus/ws/user_id_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_mojo_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 6 chunks +11 lines, -12 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/web_ui_mojo_shell_test.js View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/mojo_base.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.h View 1 1 chunk +0 lines, -205 lines 0 comments Download
D mojo/shell/application_manager.cc View 1 2 1 chunk +0 lines, -589 lines 0 comments Download
M mojo/shell/background/background_shell.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M mojo/shell/connect_params.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/connect_util.h View 1 1 chunk +11 lines, -12 lines 0 comments Download
M mojo/shell/connect_util.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/identity.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/loader.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/native_runner.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/connector.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/connector_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/interfaces/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/public/interfaces/application_manager.mojom View 1 1 chunk +0 lines, -62 lines 0 comments Download
A mojo/shell/public/interfaces/connector.mojom View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
D mojo/shell/public/interfaces/shell.mojom View 1 2 3 4 2 chunks +53 lines, -69 lines 0 comments Download
M mojo/shell/public/interfaces/shell_client.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/shell.h View 1 9 chunks +23 lines, -25 lines 0 comments Download
A + mojo/shell/shell.cc View 1 2 28 chunks +79 lines, -92 lines 0 comments Download
M mojo/shell/standalone/context.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/shell/standalone/context.cc View 1 5 chunks +9 lines, -11 lines 0 comments Download
M mojo/shell/tests/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/tests/application_manager/BUILD.gn View 1 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/shell/tests/application_manager/application_manager_unittest.cc View 1 1 chunk +0 lines, -211 lines 0 comments Download
D mojo/shell/tests/application_manager/application_manager_unittest.mojom View 1 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/shell/tests/application_manager/application_manager_unittest_manifest.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/shell/tests/application_manager/driver.cc View 1 1 chunk +0 lines, -154 lines 0 comments Download
D mojo/shell/tests/application_manager/driver_manifest.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/shell/tests/application_manager/target.cc View 1 1 chunk +0 lines, -47 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/lifecycle/lifecycle_unittest.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/shell/tests/loader_unittest.cc View 1 10 chunks +20 lines, -23 lines 0 comments Download
A + mojo/shell/tests/shell/BUILD.gn View 1 3 chunks +10 lines, -10 lines 0 comments Download
A + mojo/shell/tests/shell/driver.cc View 1 3 chunks +12 lines, -13 lines 0 comments Download
A mojo/shell/tests/shell/driver_manifest.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + mojo/shell/tests/shell/shell_unittest.cc View 1 7 chunks +32 lines, -33 lines 0 comments Download
A + mojo/shell/tests/shell/shell_unittest.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
A mojo/shell/tests/shell/shell_unittest_manifest.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + mojo/shell/tests/shell/target.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (13 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 1760963003 Patch 40001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-04 20:28:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764253002/60001
4 years, 9 months ago (2016-03-04 22:08:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/103020) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-04 22:20:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764253002/80001
4 years, 9 months ago (2016-03-04 22:52:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/103030) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-04 23:04:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764253002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764253002/100001
4 years, 9 months ago (2016-03-05 00:43:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/125911)
4 years, 9 months ago (2016-03-05 01:23:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764253002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764253002/120001
4 years, 9 months ago (2016-03-05 02:06:57 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-05 05:16:29 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 05:17:36 UTC) #23
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/15b9a8b847fe280eb141897ea4f0a60fa1060476
Cr-Commit-Position: refs/heads/master@{#379459}

Powered by Google App Engine
This is Rietveld 408576698