Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 176423002: Revert 252507 "Re-enable MetricsServiceTest.RegisterSyntheticTrial." (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 252507 "Re-enable MetricsServiceTest.RegisterSyntheticTrial." This test is failing on ~25% of win_rel try jobs and the CQ is suffering. http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/268519 http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/268515 http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/268511 > Re-enable MetricsServiceTest.RegisterSyntheticTrial. > > The test passes locally and the failure stacktrace from > the bug should have been fixed by http://crrev.com/240919. > > BUG=320433 > > Review URL: https://codereview.chromium.org/174403003 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M trunk/src/chrome/browser/metrics/metrics_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
6 years, 10 months ago (2014-02-22 20:03:31 UTC) #1
James Cook
Committed patchset #1 manually as r252821.
6 years, 10 months ago (2014-02-22 20:03:37 UTC) #2
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-24 18:02:25 UTC) #3
Message was sent while issue was closed. 
LGTM, thanks for providing failure output on the bug.

Powered by Google App Engine
This is Rietveld 408576698