Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174403003: Re-enable MetricsServiceTest.RegisterSyntheticTrial. (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)
Modified:
6 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Re-enable MetricsServiceTest.RegisterSyntheticTrial. The test passes locally and the failure stacktrace from the bug should have been fixed by http://crrev.com/240919. BUG=320433 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/metrics/metrics_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-20 23:01:57 UTC) #1
Ilya Sherman
LGTM
6 years, 10 months ago (2014-02-20 23:04:49 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-20 23:05:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/174403003/1
6 years, 10 months ago (2014-02-20 23:08:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 01:24:39 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267462
6 years, 10 months ago (2014-02-21 01:24:39 UTC) #6
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 10 months ago (2014-02-21 05:05:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/174403003/1
6 years, 10 months ago (2014-02-21 05:06:43 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 06:27:04 UTC) #9
Message was sent while issue was closed. 
Change committed as 252507

Powered by Google App Engine
This is Rietveld 408576698