Issue 176413002: Simplify storage of MC State stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176413002: Simplify storage of MC State stack (Closed)

Created:
6 years, 10 months ago by robertphillips

Modified:
6 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

I believe this makes it clearer what is going on; namely: saveLayers cause their enclosing MC state to become a prefix for their child canvas calls. In such cases we don't want to inadvertently close the nesting MC state but when we do (i.e., when the saveLayer's restore is seen) we want to also restore the nesting MC state to be the current one. Committed: http://code.google.com/p/skia/source/detail?r=13564

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -29 lines)			Patch
	M	src/core/SkMatrixClipStateMgr.h	View		5 chunks	+10 lines, -5 lines	0 comments	Download
	M	src/core/SkMatrixClipStateMgr.cpp	View		6 chunks	+8 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 10 months ago (2014-02-24 16:01:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/176413002/1

6 years, 10 months ago (2014-02-24 16:01:42 UTC) #4

Message was sent while issue was closed.

Change committed as 13564

Expand Messages | Collapse Messages