Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 176403004: parser: fix build on solaris (Closed)

Created:
6 years, 10 months ago by indutny
Modified:
6 years, 9 months ago
Reviewers:
ulan, danno, marja
CC:
v8-dev, ulan, tfarina
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

parser: fix build on solaris `FS` is defined in `regset.h` on solaris and smartos. BUG= R=ulan@chromium.org, danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/parser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/preparser.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
indutny
6 years, 10 months ago (2014-02-23 14:39:13 UTC) #1
tfarina
Copying Marja and Ulan, since Marja has been refactoring Parser and PreParser.
6 years, 10 months ago (2014-02-23 22:23:25 UTC) #2
ulan
lgtm
6 years, 10 months ago (2014-02-24 06:54:57 UTC) #3
marja
Thx for fixing!
6 years, 10 months ago (2014-02-24 08:19:42 UTC) #4
indutny
On 2014/02/24 08:19:42, marja wrote: > Thx for fixing! Thank you!
6 years, 10 months ago (2014-02-24 08:53:36 UTC) #5
marja
(I'll also land this as soon as V8 starts taking code in again :)
6 years, 10 months ago (2014-02-24 09:06:22 UTC) #6
marja
Committed patchset #1 manually as r19602 (tree was closed).
6 years, 9 months ago (2014-02-28 12:08:23 UTC) #7
indutny
On 2014/02/28 12:08:23, marja wrote: > Committed patchset #1 manually as r19602 (tree was closed). ...
6 years, 9 months ago (2014-03-13 16:45:12 UTC) #8
marja
+yangguo, I have no idea how merging back works, CC:ing the current sheriff, yangguo.
6 years, 9 months ago (2014-03-17 10:17:13 UTC) #9
Yang
On 2014/03/17 10:17:13, marja wrote: > +yangguo, > > I have no idea how merging ...
6 years, 9 months ago (2014-03-17 12:05:36 UTC) #10
indutny
On 2014/03/17 12:05:36, Yang wrote: > On 2014/03/17 10:17:13, marja wrote: > > +yangguo, > ...
6 years, 9 months ago (2014-03-17 12:12:19 UTC) #11
Jakob Kummerow
6 years, 9 months ago (2014-03-17 13:50:56 UTC) #12
Message was sent while issue was closed.
On 2014/03/17 12:12:19, indutny wrote:
> On 2014/03/17 12:05:36, Yang wrote:
> > On 2014/03/17 10:17:13, marja wrote:
> > > +yangguo,
> > > 
> > > I have no idea how merging back works, CC:ing the current sheriff,
yangguo.
> > 
> > I don't think 3.24 is even affected.
> 
> I think it is http://v8.googlecode.com/svn/tags/3.24.40/src/parser.h ... Or is
> there more up-to-date version rather than 3.24.40 ?

The 3.24 branch is based on 3.24.35. See
https://code.google.com/p/v8/source/browse/branches/3.24/src/parser.h for its
most recent version.

So I agree that no backport is necessary.

Powered by Google App Engine
This is Rietveld 408576698