Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 176403002: Revert of cc: Cleanup internal::WorkerPoolTaskClient interface. (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert of cc: Cleanup internal::WorkerPoolTaskClient interface. (https://codereview.chromium.org/170783007/) Reason for revert: Speculative revert. Suspecting that this CL may be causing a DCHECK to fire on Android in PixelBufferRasterWorkerPool::ScheduleMoreTasks( http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18755/steps/slave_steps/logs/stdio Original issue's description: > cc: Cleanup internal::WorkerPoolTaskClient interface. > > ::CompleteOnOriginThread is now called when RasterWorkerPool has > completed all necessary initialization of resource, including > texture uploads. This improves the WorkerPoolTask/Client interface > significantly and will allow better resource recycling once > ::RunReplyOnOriginThread is removed. > > BUG=269841 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252790 TBR=vmpstr@chromium.org,alokp@chromium.org,sergeyberezin@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG=269841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -218 lines) Patch
M cc/resources/direct_raster_worker_pool.h View 1 chunk +7 lines, -4 lines 0 comments Download
M cc/resources/direct_raster_worker_pool.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M cc/resources/image_raster_worker_pool.h View 1 chunk +7 lines, -4 lines 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.h View 5 chunks +16 lines, -15 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 14 chunks +101 lines, -120 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 2 chunks +7 lines, -6 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.h View 6 chunks +6 lines, -11 lines 0 comments Download
M cc/resources/resource_provider.cc View 4 chunks +11 lines, -29 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pkotwicz
Created Revert of cc: Cleanup internal::WorkerPoolTaskClient interface.
6 years, 10 months ago (2014-02-22 18:48:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/176403002/1
6 years, 10 months ago (2014-02-22 18:48:14 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 18:48:44 UTC) #3
Message was sent while issue was closed.
Change committed as 252807

Powered by Google App Engine
This is Rietveld 408576698