Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: cc/resources/resource_provider.h

Issue 176403002: Revert of cc: Cleanup internal::WorkerPoolTaskClient interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/raster_worker_pool_unittest.cc ('k') | cc/resources/resource_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/resource_provider.h
diff --git a/cc/resources/resource_provider.h b/cc/resources/resource_provider.h
index 73b5a23dcdf3c249f075946ce7a0c6deb77ac0d6..dd7e200e3e1e73b13541ebb2130f7a3396690dcf 100644
--- a/cc/resources/resource_provider.h
+++ b/cc/resources/resource_provider.h
@@ -331,15 +331,14 @@
SkCanvas* MapImageRasterBuffer(ResourceId id);
void UnmapImageRasterBuffer(ResourceId id);
- // Returns a canvas backed by pixel buffer. UnmapPixelRasterBuffer
- // returns true if canvas was written to while mapped.
+ // Returns a canvas backed by pixel buffer.
// The pixel buffer needs to be uploaded to the underlying resource
// using BeginSetPixels before the resouce can be used for compositing.
// It is used by PixelRasterWorkerPool.
void AcquirePixelRasterBuffer(ResourceId id);
void ReleasePixelRasterBuffer(ResourceId id);
SkCanvas* MapPixelRasterBuffer(ResourceId id);
- bool UnmapPixelRasterBuffer(ResourceId id);
+ void UnmapPixelRasterBuffer(ResourceId id);
// Asynchronously update pixels from acquired pixel buffer.
void BeginSetPixels(ResourceId id);
@@ -451,8 +450,7 @@
virtual ~RasterBuffer();
SkCanvas* LockForWrite();
- // Returns true if canvas was written to while locked.
- bool UnlockForWrite();
+ void UnlockForWrite();
protected:
RasterBuffer(const Resource* resource, ResourceProvider* resource_provider);
@@ -460,7 +458,7 @@
ResourceProvider* resource_provider() const { return resource_provider_; }
virtual SkCanvas* DoLockForWrite() = 0;
- virtual bool DoUnlockForWrite() = 0;
+ virtual void DoUnlockForWrite() = 0;
private:
const Resource* resource_;
@@ -477,13 +475,11 @@
protected:
virtual SkCanvas* DoLockForWrite() OVERRIDE;
- virtual bool DoUnlockForWrite() OVERRIDE;
+ virtual void DoUnlockForWrite() OVERRIDE;
skia::RefPtr<SkSurface> CreateSurface();
private:
skia::RefPtr<SkSurface> surface_;
- uint32_t surface_generation_id_;
-
DISALLOW_COPY_AND_ASSIGN(DirectRasterBuffer);
};
@@ -496,7 +492,7 @@
ResourceProvider* resource_provider);
virtual SkCanvas* DoLockForWrite() OVERRIDE;
- virtual bool DoUnlockForWrite() OVERRIDE;
+ virtual void DoUnlockForWrite() OVERRIDE;
virtual uint8_t* MapBuffer(int* stride) = 0;
virtual void UnmapBuffer() = 0;
@@ -504,7 +500,6 @@
private:
uint8_t* mapped_buffer_;
SkBitmap raster_bitmap_;
- uint32_t raster_bitmap_generation_id_;
skia::RefPtr<SkCanvas> raster_canvas_;
};
« no previous file with comments | « cc/resources/raster_worker_pool_unittest.cc ('k') | cc/resources/resource_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698