Source/WebKit/chromium/src/WebPagePopupImpl.cpp - Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebPagePopupImpl.cpp

Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-landing after fixing ASAN failure on set-parent-src-synchronously.xhtml. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebKit/chromium/src/WebPagePopupImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebPagePopupImpl.cpp b/Source/WebKit/chromium/src/WebPagePopupImpl.cpp

index 3260e8d71aa99de70ad144644148973b23f872bb..39cb44100343e50b522ba009d759cb47f3153f94 100644

--- a/Source/WebKit/chromium/src/WebPagePopupImpl.cpp

+++ b/Source/WebKit/chromium/src/WebPagePopupImpl.cpp

@@ -216,7 +216,7 @@ bool WebPagePopupImpl::initializePage()

DocumentWriter* writer = frame->loader()->activeDocumentLoader()->beginWriting("text/html", "UTF-8");

m_popupClient->writeDocument(*writer);

- writer->end();

+ frame->loader()->activeDocumentLoader()->endWriting(writer);

return true;

}

« no previous file with comments | « Source/WebKit/chromium/src/WebHelperPluginImpl.cpp ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »