Source/WebKit/chromium/src/WebHelperPluginImpl.cpp - Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebHelperPluginImpl.cpp

Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-landing after fixing ASAN failure on set-parent-src-synchronously.xhtml. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebKit/chromium/src/WebHelperPluginImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp b/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp

index bb20ab572a07b9ccfd55a5d15243eb4727c6e89b..8eb199a2f217940b34ee946f31471aa3ab43ff6f 100644

--- a/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp

+++ b/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp

@@ -73,7 +73,7 @@ static void writeDocument(const String& pluginType, const WebDocument& hostDocum

addString(objectTag, writer);

addLiteral("</body>\n", writer);

- writer->end();

+ loader->endWriting(writer);

}

class HelperPluginChromeClient : public EmptyChromeClient {