Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1763993002:
Refactoring: Have isDefaultSlotName function (Closed)
|
Created:
4 years, 9 months ago by hayato Modified:
4 years, 9 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactoring: Have isDefaultSlotName function
Minor refactoring for a default slot.
BUG=531990
Committed: https://crrev.com/4c035a193b7186d58bc072d96a893dad21edeced
Cr-Commit-Position: refs/heads/master@{#379231}
Patch Set 1 #Patch Set 2 : update #
Total comments: 2
Patch Set 3 : rename #Messages
Total messages: 25 (11 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763993002/1
Description was changed from ========== Factor out defaultSlotNmae function BUG=531990 ========== to ========== Refactoring: Have defaultSlotName function Minor refactoring for a default slot. BUG=531990 ==========
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
update
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763993002/20001
hayato@chromium.org changed reviewers: + kochi@chromium.org, tkent@chromium.org, yuzus@chromium.org
PTAL
https://codereview.chromium.org/1763993002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp (right): https://codereview.chromium.org/1763993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:28: inline static bool defaultSlotName(const AtomicString& name) Such predicate function should be named as "isDefaultSlotName".
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
rename
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763993002/40001
Description was changed from ========== Refactoring: Have defaultSlotName function Minor refactoring for a default slot. BUG=531990 ========== to ========== Refactoring: Have isDefaultSlotName function Minor refactoring for a default slot. BUG=531990 ==========
https://codereview.chromium.org/1763993002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp (right): https://codereview.chromium.org/1763993002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:28: inline static bool defaultSlotName(const AtomicString& name) On 2016/03/04 at 03:37:47, tkent wrote: > Such predicate function should be named as "isDefaultSlotName". Done
lgtm
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org Link to the patchset: https://codereview.chromium.org/1763993002/#ps40001 (title: "rename")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763993002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Refactoring: Have isDefaultSlotName function Minor refactoring for a default slot. BUG=531990 ========== to ========== Refactoring: Have isDefaultSlotName function Minor refactoring for a default slot. BUG=531990 Committed: https://crrev.com/4c035a193b7186d58bc072d96a893dad21edeced Cr-Commit-Position: refs/heads/master@{#379231} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4c035a193b7186d58bc072d96a893dad21edeced Cr-Commit-Position: refs/heads/master@{#379231} |
