Staging an example iOS project to be the dummy target for CRD iOS App.

Staging an example iOS project to be the dummy target for CRD iOS App.

Committed: https://crrev.com/64b5337d07e5ed40629d2c0eeb5202ac2a1da542
Cr-Commit-Position: refs/heads/master@{#384335}

[nicholss, 2016-03-15 23:20:52]

nicholss@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[nicholss, 2016-03-15 23:21:41]

Lambros, please take a look at my example iOS app to be used as a built target
in remoting for build bots to build iOS + WebRTC in time. This is the first
shell of a working app.

[Lambros, 2016-03-16 00:22:12]

lgtm

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/app...
File remoting/client/ios/app_delegate.mm (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/app...
remoting/client/ios/app_delegate.mm:6: #error "This file requires ARC support."
Do we need this notice here?

Even if we need ARC support, do we need to pollute every source file with this
boilerplate?

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/exa...
File remoting/client/ios/example_view_controller.mm (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/exa...
remoting/client/ios/example_view_controller.mm:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
2016

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/exa...
remoting/client/ios/example_view_controller.mm:13: @interface
ExampleViewController()
rename in future CL?

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/exa...
remoting/client/ios/example_view_controller.mm:72: glClearColor(0.0, 40.0, 0.0,
1.0);
Will this go away in a future CL?

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/mai...
File remoting/client/ios/main.mm (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/mai...
remoting/client/ios/main.mm:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
2016

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/mai...
remoting/client/ios/main.mm:16: // This class is designed to fulfill the
dependents needs when it goes out of
Feel free to remove all these comments if you like - I don't think they add any
value.

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/rem...
File remoting/client/ios/remoting_ios-Info.plist (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/rem...
remoting/client/ios/remoting_ios-Info.plist:8: <string>Chromium Remote
Desktop</string>
Maybe just "Chromoting"? Will eventually become "${PRODUCT_NAME}" but this is
fine for now.

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/opengl_...
File remoting/client/opengl_wrapper.h (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/opengl_...
remoting/client/opengl_wrapper.h:5: #ifndef REMOTING_CLIENT_OPENGL_WRAPPER_H_
Why do you need this file?

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.gypi
File remoting/remoting_ios.gypi (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.g...
remoting/remoting_ios.gypi:32: 'product_name': 'Chromium Remote Desktop',
Chromoting?

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.g...
remoting/remoting_ios.gypi:41: 'BUNDLE_IDENTIFIER':
'com.google.ChromiumRemoteDesktop',
Either Chromoting or Chrome Remote Desktop:

If you use 'google' in the name, you should use the official title Chrome Remote
Desktop (maybe chromeremotedesktop). Ideally, you'd switch based on the
'BRANDING' setting, but hard-coding is OK for now.

If you use 'chromium' or 'chromoting' anywhere in the name, you should use
'org.chromium' as the namespace.

It's sad that the official Mac desktop components use 'org.chromium.chromoting'
but we can't easily change that :(

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.g...
remoting/remoting_ios.gypi:44: '<(DEPTH)',
<(DEPTH) could be replaced with '..', since this .gypi file is only included in
one place.

[nicholss, 2016-03-16 16:40:39]

CL updated. Will push after trybots pass.

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/exa...
File remoting/client/ios/example_view_controller.mm (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/exa...
remoting/client/ios/example_view_controller.mm:13: @interface
ExampleViewController()
On 2016/03/16 00:22:11, Lambros wrote:
> rename in future CL?

Yes. This file is just temp code to make sure I can start up a GL context.

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/rem...
File remoting/client/ios/remoting_ios-Info.plist (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/ios/rem...
remoting/client/ios/remoting_ios-Info.plist:8: <string>Chromium Remote
Desktop</string>
On 2016/03/16 00:22:11, Lambros wrote:
> Maybe just "Chromoting"? Will eventually become "${PRODUCT_NAME}" but this is
> fine for now.

Calling a Chromoting Demo now. Thanks.

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/opengl_...
File remoting/client/opengl_wrapper.h (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/client/opengl_...
remoting/client/opengl_wrapper.h:5: #ifndef REMOTING_CLIENT_OPENGL_WRAPPER_H_
On 2016/03/16 00:22:11, Lambros wrote:
> Why do you need this file?

This will allow us to use the same cpp files in android and ios that use OpenGL
without needing to add the if defs to each file, they all will go here. But I do
not have the android includes here yet.

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.gypi
File remoting/remoting_ios.gypi (right):

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.g...
remoting/remoting_ios.gypi:41: 'BUNDLE_IDENTIFIER':
'com.google.ChromiumRemoteDesktop',
On 2016/03/16 00:22:12, Lambros wrote:
> Either Chromoting or Chrome Remote Desktop:
> 
> If you use 'google' in the name, you should use the official title Chrome
Remote
> Desktop (maybe chromeremotedesktop). Ideally, you'd switch based on the
> 'BRANDING' setting, but hard-coding is OK for now.
> 
> If you use 'chromium' or 'chromoting' anywhere in the name, you should use
> 'org.chromium' as the namespace.
> 
> It's sad that the official Mac desktop components use
'org.chromium.chromoting'
> but we can't easily change that :(

I can't change it for iOS builds and be able to deploy to device targets because
of certs.  

But I like this idea of Branding settings. I will have to look into that more
later. For now, this will be set to org.chromium.ChromotingDemo and I moved it
to the variables area so we can make a substitution in the future without
hunting for it.

https://codereview.chromium.org/1763783002/diff/40001/remoting/remoting_ios.g...
remoting/remoting_ios.gypi:44: '<(DEPTH)',
On 2016/03/16 00:22:12, Lambros wrote:
> <(DEPTH) could be replaced with '..', since this .gypi file is only included
in
> one place.

That works until you move things. I would prefer to know exactly where I am
including. Relative folder location problems where a large part of the issues I
had to figure out to get the build working again and if everyone had used abs
positioning for external libs rather than relative it would have been much
easier to work out the fix.

[nicholss, 2016-03-28 20:44:26]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2016-03-28 20:44:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1763783002/#ps80001
(title: "Correct comment label.")

[commit-bot: I haz the power, 2016-03-28 20:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763783002/80001

[commit-bot: I haz the power, 2016-03-28 20:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 20:54:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nicholss, 2016-03-28 21:02:01]

nicholss@chromium.org changed reviewers:
+ sadrul@chromium.org

[nicholss, 2016-03-28 21:02:30]

On 2016/03/28 20:54:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Adding sadrul@chromium.org to the review to approve the DEPS change for usage of
ui/base

[sadrul, 2016-03-30 14:32:27]

Can you refer to the relevant bug in the CL description (BUG=...)?

stamp lgtm

[nicholss, 2016-03-31 16:52:06]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:52:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763783002/80001

[nicholss, 2016-03-31 16:52:29]

The CQ bit was unchecked by nicholss@chromium.org

[nicholss, 2016-03-31 16:52:43]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:52:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763783002/80001

[commit-bot: I haz the power, 2016-03-31 17:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 17:03:09]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[nicholss, 2016-03-31 17:48:44]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2016-03-31 17:49:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763783002/80001

[commit-bot: I haz the power, 2016-03-31 18:20:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-31 18:21:41]

Description was changed from

==========
Staging an example iOS project to be the dummy target for CRD iOS App.
==========

to

==========
Staging an example iOS project to be the dummy target for CRD iOS App.

Committed: https://crrev.com/64b5337d07e5ed40629d2c0eeb5202ac2a1da542
Cr-Commit-Position: refs/heads/master@{#384335}
==========

[commit-bot: I haz the power, 2016-03-31 18:21:42]

Patchset 5 (id:??) landed as
https://crrev.com/64b5337d07e5ed40629d2c0eeb5202ac2a1da542
Cr-Commit-Position: refs/heads/master@{#384335}