Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1763733002: MIPS64: Fix 'Fix 'MIPS: use DAHI/DATH for li macro on mips64r6.'' (Closed)

Created:
4 years, 9 months ago by Alan Li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'Fix 'MIPS: use DAHI/DATH for li macro on mips64r6.'' This CL fixes the bugs caused by the following CL: 50a394d -- MIPS64: Fix 'MIPS: use DAHI/DATH for li macro on mips64r6.' Port 1f5b84e467763510b08aac64577292205dfc19c MIPS: use DAHI/DATH for li macro on mips64r6. LUI instruction would sign extend into higher 32bits, in that case we might need to use DAHI, DATI to overwrite the extension. The bug will occur when we are loading some addresses such as 0x00007fffffffxxxx. BUG= TEST=test-run-native-calls/Run_Int32_Select_*, test-run-native-calls/Run_Int32_WeightedSum_*, test-run-native-calls/Run_Int32_WeightedSum_*, test-run-native-calls/Run_Int32_Select_* Committed: https://crrev.com/4c57e05d5f50ead2f0c9b9351ca4ac672dac31ff Cr-Commit-Position: refs/heads/master@{#34467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/mips64/macro-assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
balazs.kilvady
Please fix the description. You remember? MIP64: Fix '' Port .... and so on :)
4 years, 9 months ago (2016-03-03 18:09:13 UTC) #3
Alan Li
On 2016/03/03 18:09:13, balazs.kilvady wrote: > Please fix the description. You remember? > MIP64: Fix ...
4 years, 9 months ago (2016-03-03 18:17:54 UTC) #5
balazs.kilvady
lgtm
4 years, 9 months ago (2016-03-03 18:23:50 UTC) #6
balazs.kilvady
NOT LGTM. You fixed the message, not the description, right?
4 years, 9 months ago (2016-03-03 18:25:51 UTC) #7
balazs.kilvady
On 2016/03/03 18:25:51, balazs.kilvady wrote: > NOT LGTM. You fixed the message, not the description, ...
4 years, 9 months ago (2016-03-03 18:28:09 UTC) #8
Alan Li
On 2016/03/03 18:28:09, balazs.kilvady wrote: > On 2016/03/03 18:25:51, balazs.kilvady wrote: > > NOT LGTM. ...
4 years, 9 months ago (2016-03-03 18:33:29 UTC) #10
balazs.kilvady
lgtm
4 years, 9 months ago (2016-03-03 18:35:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763733002/1
4 years, 9 months ago (2016-03-03 18:37:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 18:53:52 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 18:55:14 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c57e05d5f50ead2f0c9b9351ca4ac672dac31ff
Cr-Commit-Position: refs/heads/master@{#34467}

Powered by Google App Engine
This is Rietveld 408576698