scripts/slave/recipe_modules/rietveld/api.py - Issue 17635005: Make blink_trybot recipe work on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/rietveld/api.py

Issue 17635005: Make blink_trybot recipe work on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Fix presubmit + move polyfill (retry) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/rietveld/api.py

diff --git a/scripts/slave/recipe_modules/rietveld/api.py b/scripts/slave/recipe_modules/rietveld/api.py

index b0f5908526325b8b76dbb3949f0d51bc0db5b7cb..91486c955fb18061ef4e23fc585e62266eda4e8f 100644

--- a/scripts/slave/recipe_modules/rietveld/api.py

+++ b/scripts/slave/recipe_modules/rietveld/api.py

@@ -15,11 +15,12 @@ class RietveldApi(recipe_api.RecipeApi):

return root

def apply_issue(self, *root_pieces):

- return self.m.step('apply_issue', [

- self.m.path.depot_tools('apply_issue'),

+ return self.m.python('apply_issue',

+ self.m.path.depot_tools('apply_issue.py'), [

'-r', self.m.path.checkout(*root_pieces),

'-i', self.m.properties['issue'],

'-p', self.m.properties['patchset'],

'-s', self.m.properties['rietveld'],

- '-e', 'commit-bot@chromium.org'])

+ '-e', 'commit-bot@chromium.org',

+ '--no-commit'])