scripts/slave/recipe_modules/rietveld/api.py - Issue 17635005: Make blink_trybot recipe work on windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/rietveld/api.py

Issue 17635005: Make blink_trybot recipe work on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Fix presubmit + move polyfill (retry) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« scripts/slave/recipe_modules/gclient/api.py ('K') | « scripts/slave/recipe_modules/rietveld/__init__.py ('k') | scripts/slave/recipes/android_webview_aosp.expected/basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from slave import recipe_api	5 from slave import recipe_api

6	6

7 class RietveldApi(recipe_api.RecipeApi):	7 class RietveldApi(recipe_api.RecipeApi):

8 def calculate_issue_root(self):	8 def calculate_issue_root(self):

9 root = self.m.properties.get('root', '')	9 root = self.m.properties.get('root', '')

10 # FIXME: Rietveld passes the blink path as src/third_party/WebKit	10 # FIXME: Rietveld passes the blink path as src/third_party/WebKit

11 # so we have to strip the src bit off before passing to	11 # so we have to strip the src bit off before passing to

12 # api.checkout_path. :(	12 # api.checkout_path. :(

13 if root.startswith('src'):	13 if root.startswith('src'):

14 root = root[3:].lstrip('/')	14 root = root[3:].lstrip('/')

15 return root	15 return root

16	16

17 def apply_issue(self, *root_pieces):	17 def apply_issue(self, *root_pieces):

18 return self.m.step('apply_issue', [	18 return self.m.python('apply_issue',

19 self.m.path.depot_tools('apply_issue'),	19 self.m.path.depot_tools('apply_issue.py'), [

20 '-r', self.m.path.checkout(*root_pieces),	20 '-r', self.m.path.checkout(*root_pieces),

21 '-i', self.m.properties['issue'],	21 '-i', self.m.properties['issue'],

22 '-p', self.m.properties['patchset'],	22 '-p', self.m.properties['patchset'],

23 '-s', self.m.properties['rietveld'],	23 '-s', self.m.properties['rietveld'],

24 '-e', 'commit-bot@chromium.org'])	24 '-e', 'commit-bot@chromium.org',

	25 '--no-commit'])

25	26

OLD	NEW