Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1762753002: Move test_random.h into media/base (Closed)

Created:
4 years, 9 months ago by jrummell
Modified:
4 years, 9 months ago
Reviewers:
hubbe, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move test_random.h into media/base TEST=compiles, no code changes Committed: https://crrev.com/7191be70d9167888b9b27dd514d6b53ea4500e70 Cr-Commit-Position: refs/heads/master@{#379097}

Patch Set 1 #

Patch Set 2 : missing #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -48 lines) Patch
M media/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + media/base/test_random.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/interval_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/lru_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/media_blink.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/multibuffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D media/blink/test_random.h View 1 chunk +0 lines, -43 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jrummell
PTAL. This is just moving test-random.h into media/base so I can use it in the ...
4 years, 9 months ago (2016-03-03 19:00:35 UTC) #2
hubbe
lgtm (not owner though)
4 years, 9 months ago (2016-03-03 19:03:25 UTC) #3
DaleCurtis
You are as of a few days ago :) https://codereview.chromium.org/1744583002/ Defer to hubbe!
4 years, 9 months ago (2016-03-03 19:04:19 UTC) #4
hubbe
lgtm
4 years, 9 months ago (2016-03-03 19:12:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762753002/20001
4 years, 9 months ago (2016-03-03 21:07:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-03 21:37:09 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 21:38:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7191be70d9167888b9b27dd514d6b53ea4500e70
Cr-Commit-Position: refs/heads/master@{#379097}

Powered by Google App Engine
This is Rietveld 408576698