Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1744583002: Update OWNERS for media/ to match current team. (Closed)

Created:
4 years, 10 months ago by DaleCurtis
Modified:
4 years, 10 months ago
Reviewers:
xhwang, wolenetz
CC:
chcunningham, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, watk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update OWNERS for media/ to match current team. - Adds watk@, chcunningham@, and hubbe@ to OWNERS for media/. - Syncs OWNERS lists with latest team roster. - Deletes content/test/data OWNERS since that has parent *. FFmpeg will have to be updated separately. Forgot to do this after committership, sorry! BUG=all that the future has to offer. TEST=seem like cool folk. Committed: https://crrev.com/52b8ea3878dab51f835b9c88a54eddcff95d9fc6 Cr-Commit-Position: refs/heads/master@{#377980}

Patch Set 1 #

Patch Set 2 : Alphabetical. #

Patch Set 3 : Sync to latest version of OWNERS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M chrome/browser/media/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/media/OWNERS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/media/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/resources/media/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/media/OWNERS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
D content/test/data/media/OWNERS View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M media/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
DaleCurtis
4 years, 10 months ago (2016-02-26 18:29:01 UTC) #2
xhwang
looking good! How about other media OWNERS files?
4 years, 10 months ago (2016-02-26 18:37:29 UTC) #3
DaleCurtis
Which ones? :)
4 years, 10 months ago (2016-02-26 18:40:45 UTC) #4
DaleCurtis
Which ones? :)
4 years, 10 months ago (2016-02-26 18:40:45 UTC) #5
DaleCurtis
content/browser/media was an intentionally small set, but on further consideration I don't think it needs ...
4 years, 10 months ago (2016-02-26 18:41:55 UTC) #6
xhwang
Some reasonable subset of this list :) https://code.google.com/p/chromium/codesearch#search/&q=dalecurtis%20file:OWNERS&sq=package:chromium&type=cs
4 years, 10 months ago (2016-02-26 18:43:09 UTC) #7
DaleCurtis
Thanks for the query, it's too early... I shamefully forgot to think of that :)
4 years, 10 months ago (2016-02-26 18:58:40 UTC) #9
wolenetz
Yay! I'm now more cool :)
4 years, 10 months ago (2016-02-26 19:01:34 UTC) #11
xhwang
LGTM! More power comes with more responsibility. Use your Force cautiously :)
4 years, 10 months ago (2016-02-26 19:06:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744583002/40001
4 years, 10 months ago (2016-02-26 19:12:14 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-26 21:24:31 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 21:26:34 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/52b8ea3878dab51f835b9c88a54eddcff95d9fc6
Cr-Commit-Position: refs/heads/master@{#377980}

Powered by Google App Engine
This is Rietveld 408576698