Fix path handling when creating summaries.

Fix path handling when creating summaries.

The path passed to "--packageMode" must be converted to an absolute path
because it is used to normalize file paths (which are automatically
converted to absolute paths by the PhysicalResourceProvider.

We should not call `resourceProvider.pathContext.absolute()`.  This
seems (by its name) like it would convert its argument to an absolute
path.  But in fact it simply prepends the path with
`resourceProvider.pathContext.current`, which is `.`, and this causes
Source objects to be created referring to non-canonical paths.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8219e27009bedab4a9acf0a4b4b0903a7b1148c9

[Paul Berry, 2016-03-04 18:57:14]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[Paul Berry, 2016-03-04 18:57:15]

These fixes will be needed in order to integrate summary creation into Bazel,
since Bazel represents nearly all file paths relative to the executable's
current directory.

[scheglov, 2016-03-04 19:15:22]

LGTM

https://codereview.chromium.org/1762363002/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1762363002/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:49:
.join(io.Directory.current.absolute.path, options.packageModePath);
Should we use both absolute() and normalize()?

[Paul Berry, 2016-03-04 22:11:24]

https://codereview.chromium.org/1762363002/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1762363002/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:49:
.join(io.Directory.current.absolute.path, options.packageModePath);
On 2016/03/04 19:15:22, scheglov wrote:
> Should we use both absolute() and normalize()?

Using normalize() seems like a good idea.  Done.

I don't see the benefit of using absolute().

[Paul Berry, 2016-03-04 22:15:52]

Description was changed from

==========
Fix path handling when creating summaries.

The path passed to "--packageMode" must be converted to an absolute path
because it is used to normalize file paths (which are automatically
converted to absolute paths by the PhysicalResourceProvider.

We should not call `resourceProvider.pathContext.absolute()`.  This
seems (by its name) like it would convert its argument to an absolute
path.  But in fact it simply prepends the path with
`resourceProvider.pathContext.current`, which is `.`, and this causes
Source objects to be created referring to non-canonical paths.
==========

to

==========
Fix path handling when creating summaries.

The path passed to "--packageMode" must be converted to an absolute path
because it is used to normalize file paths (which are automatically
converted to absolute paths by the PhysicalResourceProvider.

We should not call `resourceProvider.pathContext.absolute()`.  This
seems (by its name) like it would convert its argument to an absolute
path.  But in fact it simply prepends the path with
`resourceProvider.pathContext.current`, which is `.`, and this causes
Source objects to be created referring to non-canonical paths.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8219e27009bedab4a9acf0a4b4b0903a7b1148c9
==========

[Paul Berry, 2016-03-04 22:15:54]

Committed patchset #1 (id:1) manually as
8219e27009bedab4a9acf0a4b4b0903a7b1148c9 (presubmit successful).