Fix path handling when creating summaries.

pkg/analyzer_cli/lib/src/package_analyzer.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.package_analyzer;
 
 import 'dart:core' hide Resource;
 import 'dart:io' as io;
 
 import 'package:analyzer/dart/element/element.dart';
@@ skipping 27 matching lines @@
   final ResourceProvider resourceProvider = PhysicalResourceProvider.INSTANCE;
   InternalAnalysisContext context;
   final List<Source> explicitSources = <Source>[];
 
   PackageAnalyzer(this.options);
 
   /**
    * Perform package analysis according to the given [options].
    */
   ErrorSeverity analyze() {
-    packagePath = options.packageModePath;
+    packagePath = resourceProvider.pathContext
+        .join(io.Directory.current.absolute.path, options.packageModePath);

[scheglov, 2016/03/04 19:15:22]

Should we use both absolute() and normalize()?

[Paul Berry, 2016/03/04 22:11:23]

Using normalize() seems like a good idea.  Done.

I don't see the benefit of using absolute().

     packageLibPath = resourceProvider.pathContext.join(packagePath, 'lib');
     if (packageLibPath == null) {
       errorSink.writeln('--package-mode-path must be set to the root '
           'folder of the package to analyze.');
       io.exitCode = ErrorSeverity.ERROR.ordinal;
       return ErrorSeverity.ERROR;
     }
 
     // Write the progress message.
     if (!options.machineFormat) {
       outSink.writeln("Analyzing sources ${options.sourceFiles}...");
     }
 
     // Prepare the analysis context.
     _createContext();
 
     // Add sources.
     ChangeSet changeSet = new ChangeSet();
     for (String path in options.sourceFiles) {
       if (AnalysisEngine.isDartFileName(path)) {
-        path = resourceProvider.pathContext.absolute(path);
         File file = resourceProvider.getFile(path);
         if (!file.exists) {
           errorSink.writeln('File not found: $path');
           io.exitCode = ErrorSeverity.ERROR.ordinal;
           return ErrorSeverity.ERROR;
         }
         Source source = _createSourceInContext(file);
         explicitSources.add(source);
         changeSet.addedSource(source);
       }
@@ skipping 94 matching lines @@
         sink,
         options,
         (AnalysisError error) =>
             AnalyzerImpl.processError(error, options, context));
     for (Source source in explicitSources) {
       AnalysisErrorInfo errorInfo = context.getErrors(source);
       formatter.formatErrors([errorInfo]);
     }
   }
 }