Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1762313002: Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage Now that the embedder side supports v8::kGCCallbackFlagCollectAllAvailableGarbage, this CL removes the old v8::kGCCallbackFlagForced from Heap::CollectAllAvailableGarbage. BUG=591463 LOG=Y Committed: https://crrev.com/2436674c97f9e0bbc46a4bd75317e6470b4e720d Cr-Commit-Position: refs/heads/master@{#34517}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/global-handles.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-04 16:09:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 16:10:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762313002/1
4 years, 9 months ago (2016-03-07 05:17:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 05:49:14 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2436674c97f9e0bbc46a4bd75317e6470b4e720d Cr-Commit-Position: refs/heads/master@{#34517}
4 years, 9 months ago (2016-03-07 05:50:02 UTC) #10
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1771753002/ by hablich@chromium.org. ...
4 years, 9 months ago (2016-03-07 09:47:29 UTC) #11
jochen (gone - plz use gerrit)
mind uploading a new CL for the reland?
4 years, 9 months ago (2016-03-07 11:50:28 UTC) #13
haraken
On 2016/03/07 11:50:28, jochen wrote: > mind uploading a new CL for the reland? PS2 ...
4 years, 9 months ago (2016-03-07 11:51:32 UTC) #14
haraken
On 2016/03/07 11:51:32, haraken wrote: > On 2016/03/07 11:50:28, jochen wrote: > > mind uploading ...
4 years, 9 months ago (2016-03-07 12:31:26 UTC) #15
jochen (gone - plz use gerrit)
On 2016/03/07 at 12:31:26, haraken wrote: > On 2016/03/07 11:51:32, haraken wrote: > > On ...
4 years, 9 months ago (2016-03-07 12:33:15 UTC) #16
haraken
4 years, 9 months ago (2016-03-07 12:39:13 UTC) #17
On 2016/03/07 12:33:15, jochen wrote:
> On 2016/03/07 at 12:31:26, haraken wrote:
> > On 2016/03/07 11:51:32, haraken wrote:
> > > On 2016/03/07 11:50:28, jochen wrote:
> > > > mind uploading a new CL for the reland?
> > > 
> > > PS2 is the updated CL. I'm now waiting for chromium bot results.
> > > 
> > > But PTAL :)
> > 
> > Those tests pass. PTAL.
> 
> could you please update a new CL for the reland?

ah, you meant a new issue. Done: https://codereview.chromium.org/1769893002

Powered by Google App Engine
This is Rietveld 408576698