Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1769893002: Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage Now that the embedder side supports v8::kGCCallbackFlagCollectAllAvailableGarbage, this CL removes the old v8::kGCCallbackFlagForced from Heap::CollectAllAvailableGarbage. BUG=591463 LOG=Y Committed: https://crrev.com/9ff9592cb206ee8667120c5cbdfe6868ce498e7d Cr-Commit-Position: refs/heads/master@{#34539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/global-handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-07 12:40:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-07 12:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769893002/1
4 years, 9 months ago (2016-03-07 12:51:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 13:05:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 13:06:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ff9592cb206ee8667120c5cbdfe6868ce498e7d
Cr-Commit-Position: refs/heads/master@{#34539}

Powered by Google App Engine
This is Rietveld 408576698