content/browser/accessibility/browser_accessibility_mac_unittest.mm - Issue 1762143002: Use unique IDs for accessibility nodes on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_mac_unittest.mm

Issue 1762143002: Use unique IDs for accessibility nodes on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix null obj deref in DCHECK Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_mac.mm ('k') | content/browser/accessibility/browser_accessibility_manager_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_mac_unittest.mm

diff --git a/content/browser/accessibility/browser_accessibility_mac_unittest.mm b/content/browser/accessibility/browser_accessibility_mac_unittest.mm

index c85957fab59e7d2773e4897dc0a8611b91dad70a..0b2511dc09d505c221343fe415b3c107b2203832 100644

--- a/content/browser/accessibility/browser_accessibility_mac_unittest.mm

+++ b/content/browser/accessibility/browser_accessibility_mac_unittest.mm

@@ -8,6 +8,7 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "content/browser/accessibility/browser_accessibility_cocoa.h"

+#include "content/browser/accessibility/browser_accessibility_mac.h"

#include "content/browser/accessibility/browser_accessibility_manager.h"

#include "content/browser/accessibility/browser_accessibility_manager_mac.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -53,7 +54,7 @@ class BrowserAccessibilityTest : public ui::CocoaTest {

nil,

MakeAXTreeUpdate(root, child1, child2),

NULL));

- accessibility_.reset([manager_->GetRoot()->ToBrowserAccessibilityCocoa()

+ accessibility_.reset([ToBrowserAccessibilityCocoa(manager_->GetRoot())

retain]);

}